Don't trigger rubocop Jenkins job for changes that only modify php or js files
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	Nov 6 2014, 12:19 PM

Description

Change https://gerrit.wikimedia.org/r/#/c/171326/ shouldn't have to trigger bundle-rubocop.

Affects at least mediawiki-extensions-VisualEditor and oojs-ui repos, probably more.

Details

Reference: bz73077

	Subject	Repo	Branch	Lines +/-
	rubocop: Run *-bundle-rubocop only if relevant files were modified	integration/config	master	+9 -0

Customize query in gerrit

Related Objects

Mentioned In: rCICF5f46d88a9eb3: rubocop: Run *-bundle-rubocop only if relevant files were modified

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:53 AM

• bzimport added a project: Continuous-Integration-Infrastructure.

• bzimport set Reference to bz73077.

• bzimport added a subscriber: Unknown Object (MLST).

Krinkle created this task.Nov 6 2014, 12:19 PM

Seems we should only trigger it when .rubocop.* or .rb files are changed.

In Zuul something like:

jobs:

name: '^.*-rubocop$' files: '(^\.rubocop\..*|.*\.rb$)'

The same files: statement would have to be added to any other rubocop jobs defined as non voting in the jobs section. Ie:

name: mediawiki-core-bundle-rubocop voting: false

+ files: '(^\.rubocop\..*|.*\.rb$)'

Unassigning myself, I am not working on it.

hashar lowered the priority of this task from Medium to Lowest.Nov 24 2014, 11:40 AM

hashar set Security to None.

zeljkofilipin unsubscribed.Dec 3 2014, 12:50 PM

Krinkle renamed this task from Jenkins: Don't trigger rubocop for changes that only modify php or js files to Don't trigger rubocop Jenkins job for changes that only modify php or js files.Jan 30 2015, 12:35 AM

Krinkle updated the task description. (Show Details)

Krinkle added a project: VisualEditor.

Krinkle removed a subscriber: Unknown Object (MLST).

Krinkle updated the task description. (Show Details)Jan 30 2015, 12:41 AM

Krinkle removed a project: VisualEditor.

Change 187805 had a related patch set uploaded (by Krinkle):
rubocop: Run *-bundle-rubocop only if relevant files were modified

https://gerrit.wikimedia.org/r/187805

Patch-For-Review

Change 187805 merged by jenkins-bot:
rubocop: Run *-bundle-rubocop only if relevant files were modified

https://gerrit.wikimedia.org/r/187805

Krinkle mentioned this in rCICF5f46d88a9eb3: rubocop: Run *-bundle-rubocop only if relevant files were modified.Jan 31 2015, 2:46 AM

Krinkle closed this task as Resolved.Jan 31 2015, 2:48 AM

Krinkle claimed this task.

Confirmed that Rubocop still runs on e.g. https://gerrit.wikimedia.org/r/187166 which has a Ruby file.

Don't trigger rubocop Jenkins job for changes that only modify php or js filesClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Don't trigger rubocop Jenkins job for changes that only modify php or js files
Closed, ResolvedPublic
Actions