Page MenuHomePhabricator
Create Task
Maniphest T75147

MySQLPageGenerator fall back to .my.cnf if config.db_hostname etc are not set
Closed, ResolvedPublic
Actions

Description

defaults are now

DATABASE SETTINGS

db_hostname = 'localhost'
db_username = 'wikiuser'
db_password = ''

but falling back to .my.cnf would allow direct usage on e.g. labs.

Version: core-(2.0)
Severity: normal

Details

Reference
bz73147
SubjectRepoBranchLines +/-
MySQLPageGenerator fall back to .my.cnf if config.db_hostname etc are not setpywikibot/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:57 AM
• bzimport added a project: Pywikibot-pagegenerators.py.
• bzimport set Reference to bz73147.
• bzimport added a subscriber: Unknown Object (????).
valhallasw created this task.Nov 7 2014, 6:35 PM
Aklapper added a project: Pywikibot.Nov 27 2014, 4:10 PM
jayvdb moved this task from Backlog to Wikimedia prod/Cloud Services issues on the Pywikibot board.Nov 30 2014, 12:44 PM
jayvdb mentioned this in T75151: Site object becomes a string in MySQLPageGenerator, throws error.Dec 13 2014, 1:14 AM
eranroz subscribed.Dec 13 2014, 8:08 AM

see related change: https://gerrit.wikimedia.org/r/#/c/179560/

jayvdb added a project: good first task.Dec 17 2014, 3:33 AM
jayvdb subscribed.

With the new connect(read_default_file=config.db_connect_file,...) , I suspect the ( good first task ) fix for this bug is to now add a default in config2.py : db_connect_file = os.path.expanduser('~.my.cnf')

gerritbot added a project: Patch-For-Review.Jan 17 2015, 7:31 AM
gerritbot subscribed.

Change 185618 had a related patch set uploaded (by 01tonythomas):
MySQLPageGenerator fall back to .my.cnf if config.db_hostname etc are not set

https://gerrit.wikimedia.org/r/185618

Patch-For-Review

gerritbot added a comment.Jan 17 2015, 10:08 AM

Change 185618 merged by jenkins-bot:
MySQLPageGenerator fall back to .my.cnf if config.db_hostname etc are not set

https://gerrit.wikimedia.org/r/185618

jayvdb closed this task as Resolved.Jan 30 2015, 6:46 AM
jayvdb claimed this task.
Mpaa removed a project: Patch-For-Review.Jan 30 2015, 10:38 PM
Mpaa set Security to None.
01tonythomas mentioned this in rPWBC0b85c5035477: MySQLPageGenerator fall back to .my.cnf if config.db_hostname etc are not set.Mar 4 2015, 8:46 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL