Page MenuHomePhabricator
Create Task
Maniphest T75460

[Story] Make Lua functions default to the user's language on multilingual wikis
Closed, ResolvedPublic
Actions

Description

On a multilingual wiki (where allowDataAccessInUserLanguage is true), the Lua functions should use the user's language (eg. for getting labels, but also for rendering Snaks or the like).

Details

Reference
bz73460
SubjectRepoBranchLines +/-
Use the user's language in DataAccess if allowDataAccessInUserLanguagemediawiki/extensions/Wikibasemaster+165 -101
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
OpenNoneT75087 Efficient entity label lookup (tracking)
ResolvedNoneT49930 [Epic] Allow accessing data from a Wikidata item not connected to the current page - arbitrary access
OpenNoneT76159 [Task] Preload labels and descriptions for Lua and the parser function based on usage tracking data
ResolvedLydia_PintscherT89002 multi-lingual label usage [Tracking]
ResolvedhooT75460 [Story] Make Lua functions default to the user's language on multilingual wikis
· · ·

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 4:00 AM
• bzimport added a project: MediaWiki-extensions-WikibaseClient.
• bzimport set Reference to bz73460.
• bzimport added a subscriber: Unknown Object (MLST).
hoo created this task.Nov 15 2014, 11:34 AM
Lydia_Pintscher added subscribers: Multichill, TheDJ.Nov 26 2014, 11:15 AM
Lydia_Pintscher added a project: Wikidata.Dec 1 2014, 2:24 PM
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
hoo added a project: Performance Issue.Dec 4 2014, 10:39 PM
hoo set Security to None.
mxn subscribed.Dec 5 2014, 5:10 AM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2014-12-09§.Dec 9 2014, 4:30 PM
• GWicke subscribed.Dec 9 2014, 4:34 PM

Please make sure that the language(s) used are static for anything in the content of a page. In particular, it should not depend on the user interface language, as that would impose a heavy performance penalty on the user.

hoo mentioned this in T76159: [Task] Preload labels and descriptions for Lua and the parser function based on usage tracking data.Dec 11 2014, 2:29 PM
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Jan 8 2015, 10:27 PM
Liuxinyu970226 subscribed.Feb 8 2015, 1:46 AM
hoo mentioned this in T88924: [Story] Make Snak rendering use user language instead of content language for multilingual wikis.Feb 8 2015, 11:52 AM
Daniel_Mietchen subscribed.Feb 19 2015, 9:27 PM
hoo updated the task description. (Show Details)Jul 19 2015, 5:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2015, 5:07 PM
hoo merged a task: T101280: Render labels in the user language on the client (via Lua or parser function), split parser cache.Jul 19 2015, 5:07 PM
hoo added subscribers: daniel, Rical, Ricordisamoa.
• Jonas renamed this task from Sane Lua label access in non-content languages to [Story] Sane Lua label access in non-content languages.Sep 10 2015, 2:25 PM
daniel updated the task description. (Show Details)Sep 15 2015, 10:20 AM
daniel added a parent task: T89002: multi-lingual label usage [Tracking].
aude added a subtask: T109705: [Task] Consistently and correctly get target or 'cached' language in ParserOptions when userlang option is used.Sep 15 2015, 10:31 AM
JanZerebecki added a project: Story.Sep 25 2015, 8:28 PM
hoo renamed this task from [Story] Sane Lua label access in non-content languages to [Story] Sane Lua label access in user language.Oct 5 2015, 8:41 AM
hoo updated the task description. (Show Details)
hoo updated the task description. (Show Details)Oct 5 2015, 8:43 AM
hoo renamed this task from [Story] Sane Lua label access in user language to [Story] Make DataAccess functions default to the user's language on multilingual wikis.Oct 5 2015, 1:40 PM
hoo renamed this task from [Story] Make DataAccess functions default to the user's language on multilingual wikis to [Story] Make Lua functions default to the user's language on multilingual wikis.
hoo updated the task description. (Show Details)
hoo updated the task description. (Show Details)
gerritbot subscribed.Oct 5 2015, 1:46 PM

Change 243645 had a related patch set uploaded (by Hoo man):
Use the user's language in DataAccess if allowDataAccessInUserLanguage

https://gerrit.wikimedia.org/r/243645

gerritbot added a project: Patch-For-Review.Oct 5 2015, 1:46 PM
hoo removed a subtask: T109705: [Task] Consistently and correctly get target or 'cached' language in ParserOptions when userlang option is used.Oct 5 2015, 3:13 PM
gerritbot added a comment.Oct 17 2015, 12:57 PM

Change 243645 merged by jenkins-bot:
Use the user's language in DataAccess if allowDataAccessInUserLanguage

https://gerrit.wikimedia.org/r/243645

hoo closed this task as Resolved.Oct 17 2015, 2:18 PM
hoo claimed this task.
hoo edited projects, added Wikidata-Sprint-2015-10-13; removed Patch-For-Review.
hoo moved this task from Proposed to Done on the Wikidata-Sprint-2015-10-13 board.
Liuxinyu970226 unsubscribed.Oct 18 2015, 12:56 AM
Zolo subscribed.EditedAug 13 2016, 10:45 AM

There is a problem that we had not noticed before: T140792.

mw.wikibase.label() takes into account the user's default language, and does not change language when ?uselang=xx is added to the URL. This is
I see two possible solutions:

  1. change the behavior of mw.wikibase.label() so that it takes into account ?uselang
  2. provide a Lua function that retrieves the user's language using the same criteria as mw.wikibase.label() so that we can adapt Lua modules to fix the ?uselang= issue locally.
Zolo mentioned this in T142903: Get sitelink from Item without loading the full Item (via Lua)..Aug 13 2016, 10:59 AM
hoo mentioned this in T142906: Data access in user language doesn't obey the uselang get parameter.Aug 13 2016, 12:59 PM
In T75460#2550259, @Zolo wrote:

There is a problem that we had not noticed before: T140792.
…

I've created T142906: Data access in user language doesn't obey the uselang get parameter for that.

Rical unsubscribed.Mar 20 2018, 10:45 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL