Cannot find transaction info for some events
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Nov 24 2014, 4:56 AM

Description

Occasionally lines show up in IRC with just a user and no transaction info. This happens because we currently compare timestamps to get transaction info, and hope they're equal. This works for ~70% of cases, but fails, with timestamps being in the past or even in the future. I can easily reproduce this on phab-01.wmflabs.org by spamming comments on a bug and watching which transactions are found and which ones are missing.

On https://phab-01.wmflabs.org/T110: comment "eeek41" had an epoch of 1416804529 from feed.query, but in maniphest.gettasktransactions it reports a dateCreated of 1416804527.

Details

	Subject	Repo	Branch	Lines +/-
	Use transactionPHIDs when getting task transactions	labs/tools/wikibugs2	master	+5 -6

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	Legoktm	T647 wikibugs should Ignore CC changes
Resolved	Legoktm	T75710 Cannot find transaction info for some events
		· · ·

Event Timeline

Legoktm created this task.Nov 24 2014, 4:56 AM

Legoktm raised the priority of this task from to Needs Triage.

Legoktm updated the task description. (Show Details)

Legoktm added a project: Wikibugs.

Legoktm changed Security from none to None.

Legoktm added a subtask: T647: wikibugs should Ignore CC changes.

Legoktm removed a subtask: T647: wikibugs should Ignore CC changes.

Legoktm subscribed.

twentyafterfour deployed a small patch of mine to phab-01 which outputs the transaction phid, giving us exactly what we need (for now at least :P)

--- a/src/applications/maniphest/conduit/ManiphestGetTaskTransactionsConduitAPIMethod.php
+++ b/src/applications/maniphest/conduit/ManiphestGetTaskTransactionsConduitAPIMethod.php
@@ -63,6 +63,7 @@ final class ManiphestGetTaskTransactionsConduitAPIMethod
       }
 
       $results[$task_id][] = array(
+        'phid' => $transaction->getPHID(),
         'taskID'  => $task_id,
         'transactionType'  => $transaction->getTransactionType(),
         'oldValue'  => $transaction->getOldValue(),

I'll file an upstream bug and see if they'd be willing to accept this patch (or another solution).

This has been fixed upstream in https://secure.phabricator.com/T6629. Need to work with @chasemp to get it cherry-picked to production.

Legoktm mentioned this in T1204: Ignore moving projects on a workboard by default.Nov 25 2014, 11:23 PM

Legoktm mentioned this in T76246: wikibugs should ignore tokens changes.Nov 29 2014, 9:16 PM

• MZMcBride subscribed.Nov 29 2014, 9:21 PM

valhallasw triaged this task as High priority.Nov 30 2014, 3:31 PM

valhallasw moved this task from Backlog to Ready to Go on the Wikibugs board.Nov 30 2014, 3:35 PM

Legoktm mentioned this in T647: wikibugs should Ignore CC changes.Dec 4 2014, 7:35 AM

Aklapper mentioned this in T77082: update phabricator on 2014-12-10.Dec 8 2014, 10:11 PM

Change 178874 had a related patch set uploaded (by Legoktm):
Use transactionPHIDs when getting task transactions

https://gerrit.wikimedia.org/r/178874

Patch-For-Review

Change 178874 merged by Legoktm:
Use transactionPHIDs when getting task transactions

https://gerrit.wikimedia.org/r/178874

Deployed.

Legoktm mentioned this in rTWBTdbe2a45ae547: Use transactionPHIDs when getting task transactions.Apr 8 2015, 6:46 PM

bd808 moved this task from Ready to Go to Doing on the Wikibugs board.Sun, Mar 24, 7:57 PM

Maintenance_bot removed a project: Patch-For-Review.Sun, Mar 24, 8:30 PM

Cannot find transaction info for some eventsClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Cannot find transaction info for some events
Closed, ResolvedPublic
Actions

Related Objects
Search...