Page MenuHomePhabricator

Special:Statistic content pages incremental and full (re)calculation should do the same
Open, LowPublic

Description

Special:Statistic content pages incremental and full (re)calculation should do the same. initSiteStats.php calculates the number of content pages differently. Both should increment for every item that is not empty and not a redirect.

Event Timeline

Lucie created this task.Nov 27 2014, 2:39 PM
Lucie raised the priority of this task from to Needs Triage.
Lucie updated the task description. (Show Details)
Lucie changed Security from none to None.
Lucie added subscribers: Lucie, JanZerebecki.
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher triaged this task as Low priority.Dec 3 2014, 1:05 PM
Lydia_Pintscher added a subscriber: daniel.

Well, it is a content page isn't it?

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2015, 11:37 AM

The problem here is that the maintenance script recomputes the number differently than the incremental update process.

So in-fact the issue is with initSiteStats.php?

I thought Content pages was supposed to not count stubs?

daniel added a comment.EditedNov 1 2015, 11:07 PM

@JanZerebecki:

ItemContent has:

	 public function isCountable( $hasLinks = null ) {
		 return !$this->isRedirect() && !$this->getItem()->isEmpty();
	 }

This could easily be changed to

	 public function isCountable( $hasLinks = null ) {
		 return !$this->isRedirect() && !$this->isStub();
	 }

I seem to remember that we discussed this at some point, but I do not recall why we decided to count stubs.

I wonder why initSiteStats.php would come to a different result if it's using Content::isCountable()

At some point in the past we decided that we count even nearly empty items as articles. I don't see a reason to revise that atm.

JanZerebecki renamed this task from Special:Statistic increments number of content pages when new Item is created to Special:Statistic content pages incremental and full (re)calculation should do the same.Nov 2 2015, 1:36 PM
JanZerebecki updated the task description. (Show Details)