Page MenuHomePhabricator
Create Task
Maniphest T76946

mw.wikibase.getEntityObject returns mutable tables which are shared across invokes
Closed, ResolvedPublic
Actions

Description

That allows passing state between invokes by simply modifying those tables.

Details

SubjectRepoBranchLines +/-
Clone cached tables before returning them to users in mw.wikibasemediawiki/extensions/Wikibasewmf/1.25wmf12c+16 -5
Clone cached tables before returning them to users in mw.wikibasemediawiki/extensions/Wikibasewmf/1.25wmf10+16 -5
Clone cached tables before returning them to users in mw.wikibasemediawiki/extensions/Wikibasemaster+16 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

hoo created this task.Dec 6 2014, 5:54 PM
hoo raised the priority of this task from to High.
hoo updated the task description. (Show Details)
hoo added projects: Tracking-Neverending, Scribunto.
hoo changed Security from none to None.
hoo added subscribers: Unknown Object (MLST), Anomie, He7d3r and 5 others.
hoo added subscribers: Lydia_Pintscher, aude, daniel.
gerritbot added a project: Patch-For-Review.Dec 8 2014, 3:09 AM

Change 177991 had a related patch set (by Hoo man) published:
Clone cached tables before returning them to users in mw.wikibase

https://gerrit.wikimedia.org/r/177991

Patch-For-Review

gerritbot added a comment.Dec 8 2014, 12:11 PM

Change 177991 merged by jenkins-bot:
Clone cached tables before returning them to users in mw.wikibase

https://gerrit.wikimedia.org/r/177991

gerritbot added a comment.Dec 8 2014, 9:22 PM

Change 178273 had a related patch set uploaded (by Aude):
Clone cached tables before returning them to users in mw.wikibase

https://gerrit.wikimedia.org/r/178273

Patch-For-Review

gerritbot added a comment.Dec 8 2014, 9:34 PM

Change 178273 merged by jenkins-bot:
Clone cached tables before returning them to users in mw.wikibase

https://gerrit.wikimedia.org/r/178273

hoo closed this task as Resolved.Dec 8 2014, 11:07 PM
hoo claimed this task.
hoo mentioned this in rEWBA37c1ab3eb193: Clone cached tables before returning them to users in mw.wikibase.Dec 10 2014, 8:30 PM
aude mentioned this in rEWBAa33baac47bed: Clone cached tables before returning them to users in mw.wikibase.Dec 10 2014, 8:37 PM
gerritbot added a comment.Dec 15 2014, 11:35 PM

Change 180057 had a related patch set uploaded (by Aude):
Clone cached tables before returning them to users in mw.wikibase

https://gerrit.wikimedia.org/r/180057

Patch-For-Review

gerritbot added a comment.Dec 16 2014, 12:14 AM

Change 180057 merged by jenkins-bot:
Clone cached tables before returning them to users in mw.wikibase

https://gerrit.wikimedia.org/r/180057

aude mentioned this in rEWBAec531510e7bd: Clone cached tables before returning them to users in mw.wikibase.Dec 16 2014, 12:15 AM
Diffusion mentioned this in rMEXT4be0d72fc3e9: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Mar 11 2015, 6:22 AM
Danny_B removed a project: Tracking-Neverending.Feb 14 2016, 3:47 PM
Danny_B removed a subscriber: • wikibugs-l-list.
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
LennardHofmann mentioned this in T203357: Lookup of cached entities by mw.wikibase.getEntity in Wikipedia as a client of Wikidata is very slow.Jun 5 2022, 9:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits