Page MenuHomePhabricator

Internal links to the current page (sections, references) don't work in media viewer captions
Open, LowPublic

Description

In thumbnails in media viewer, links to other pages work, but links to the same page don't work, for example section links or references. The links are put in the browser url, but not loaded. This behavior is consistent among browsers and devices (tested : firefox and chrome on windows, safari on ios, chrome on android).

Event Timeline

Cenarium raised the priority of this task from to Needs Triage.
Cenarium updated the task description. (Show Details)
Cenarium added a project: MediaViewer.
Cenarium changed Security from none to None.
Cenarium subscribed.

I can't reproduce this. Do you have an example at hand?

The image with four references in the caption in this article :
https://en.wikipedia.org/wiki/Zhou_Yongkang#Downfall
Clicking the references when in media viewer doesn't load them.

Tgr renamed this task from Internal links to the current page (sections, references) don't work in media viewer thumbnails to Internal links to the current page (sections, references) don't work in media viewer captions.Dec 7 2014, 6:46 PM

MediaViewer hides the current page with display:none; that is undone when the URL is changed (which is too late for the anchor to work).

The clean solution (if it's possible at all, of which I am not sure) would be to leave the page visible and use position:fixed to replace it with the MediaViewer container. This would also solve the scroll position issues (maybe), but it's a rather complex change.

We could try to close MediaViewer in the click handler of the links in the caption (before the browser handles the link) or replay the URL change / manually scroll to the anchor after MediaViewer has closed; both of those are rather dirty solutions.

Gilles triaged this task as Medium priority.Dec 8 2014, 1:03 PM
Gilles subscribed.

Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's Multimedia team.

Jdlrobson lowered the priority of this task from Medium to Low.Feb 2 2016, 6:33 PM
Jdlrobson subscribed.