Re-enable Media Viewer from a File Page
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	MingleTerminator
	Dec 8 2014, 6:09 PM

Description

Migrated from: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/719

Narrative

As a user who wishes to re-enable Media Viewer, I want an easy way to re-enable it from a File: Page.

Acceptance Criteria

Below the image, show a "Open in Media Viewer" button with a cog icon.
When clicking the "View in Media Viewer" the user opens Media viewer.
When clicking the cog, the user opens Media Viewer with the settings panel opened.
If Media Viewer is disabled, the first time the user access the File Page a confirmation tooltip is shown to indicate that the current view is not the default.

We should also plan to release #870 along with this feature (Rename Media Viewer button on File page). It has already been accepted and should go out at the same time.

Design Notes

A prototype is available at http://pauginer.github.io/prototypes/media-viewer/desk/workflow/index.html#fp-f

entry points for Media Viewer on File Page:

Screen_Shot_2014-09-.png (575×819 px, 550 KB)

The button group should follow the style of mw-ui button groups
Cog icon is available here
Initially it will have an opacity of 0.75, becoming full-opacity on hover.

The first time the user disables Media Viewer, once the user reaches the File page, a notification is shown to illustrate how to access Media viewer:

Screen_Shot_20.39.png (591×819 px, 508 KB)

The tooltip can be dismissed by clicking on the "X" or outside.
Tooltip color is #EEE, gray text is #333 ).
Close "X" icon is available here
Initially it will have an opacity of 0.75, becoming full-opacity on hover.

Related Bugs

Details

	Subject	Repo	Branch	Lines +/-
	Add browser tests for options menu on file page	mediawiki/extensions/MultimediaViewer	master	+137 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T77625 Re-enable Media Viewer from a File Page
		Declined		zeljkofilipin	T77373 Add E2E test for "Expand" links on file pages

Event Timeline

In mingle on 2014-09-03 at 20:26:23, @Tgr wrote:

File pages will be a source of confusion if they have a disable switch. At least the text should include the sitename ("disable previews on Wikimedia Commons" or something like that).

In mingle on 2014-09-08 at 16:30:24, @Pginer-WMF wrote:

I have updated the designs, there is no longer a switch on the file page, but an entry point to Media viewer. Let me know if you still find it problematic.

In mingle on 2014-09-09 at 13:54:19, @Tgr wrote:

While it is generally nice to have the same functionality in a single place, the fundamental problem is that it is hard to understand which site a Commons file page belongs to. I don't think there is any way to get around that, short of not offering a disable switch on the file page at all. At a minimum, the text of the dialog should clarify what's going to happen, IMO.

In mingle on 2014-09-16 at 12:42:23, @Pginer-WMF wrote:

Added comments, and linked to image assets. Add the "design needed" tag if anything else is needed.

In mingle on 2014-10-03 at 11:36:44, @Tgr wrote:

https://gerrit.wikimedia.org/r/164529

In mingle on 2014-10-03 at 11:36:53, @Tgr wrote:

https://gerrit.wikimedia.org/r/164530

In mingle on 2014-10-15 at 14:39:17, @Tgr wrote:

Blocked on #836 as the details of setting the popup flag will depend on what decision is made there about handling the AJAX pref change.

In mingle on 2014-10-20 at 15:51:09, @Tgr wrote:

https://gerrit.wikimedia.org/r/#/c/164529/
https://gerrit.wikimedia.org/r/#/c/164530/
https://gerrit.wikimedia.org/r/#/c/167419/

In mingle on 2014-10-20 at 15:53:51, @Tgr wrote:

Done, except that the expand button icon needs to be fixed.

In mingle on 2014-10-20 at 17:20:14, @Tgr wrote:

Probably overspent by one point at least; had some trouble with the E2E tests (I could not find good documentation for the pageobject+rspec combination anywhere so there was a lot of guessing about the right syntax involved) plus a weird tipsy bug (bug 72267).