Page MenuHomePhabricator
Create Task
Maniphest T78032

Selected state of panel controls is blue, but for ButtonSelectWidgets is grey, in MediaWiki theme
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

See screenshot:

Screen_Shot_2014-12-09_at_11.23.12.png (509×790 px, 56 KB)

Details

SubjectRepoBranchLines +/-
MediaWiki Theme: Adjust ButtonSelectWidget, ButtonGroupWidget highlightsoojs/uimaster+55 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Dec 9 2014, 8:03 PM
Jdforrester-WMF raised the priority of this task from to Needs Triage.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF changed Security from none to None.
Jdforrester-WMF subscribed.
Jdforrester-WMF added projects: VisualEditor, OOUI, VisualEditor-MediaWiki.Dec 9 2014, 8:21 PM
Jdforrester-WMF triaged this task as High priority.Dec 9 2014, 8:33 PM
Jdforrester-WMF moved this task from Backlog to Next-up on the OOUI board.Dec 9 2014, 8:35 PM
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Dec 9 2014, 8:38 PM
Jdforrester-WMF added a subtask: T78082: Decide whether or not to use hover to indicate which item in menus/etc. we're about to select, in the MediaWiki theme.Dec 9 2014, 10:35 PM
• TrevorParscal subscribed.Dec 9 2014, 10:38 PM

In the MediaWiki theme, selected is shown as gray - the same as seen with ButtonOptionWidget. This is to avoid selected things from looking clickable (since they use a solid blue treatment for primary actions. The Apex highlight color is also not in the MediaWiki color set.

Jdforrester-WMF added a comment.Dec 9 2014, 10:41 PM
In T78032#835199, @TrevorParscal wrote:

In the MediaWiki theme, selected is shown as gray - the same as seen with ButtonOptionWidget. This is to avoid selected things from looking clickable (since they use a solid blue treatment for primary actions. The Apex highlight color is also not in the MediaWiki color set.

So… if the selected colour is grey, should it be grey in the booklet?

• TrevorParscal mentioned this in T78047: We need to pick a highlight colour and use it consistently in VisualEditor when using the OOjs UI MediaWiki theme.Dec 9 2014, 11:15 PM
Jdforrester-WMF closed subtask T78082: Decide whether or not to use hover to indicate which item in menus/etc. we're about to select, in the MediaWiki theme as Resolved.Dec 11 2014, 9:19 PM
Jdforrester-WMF closed this task as Resolved.Dec 11 2014, 10:26 PM
Jdforrester-WMF assigned this task to • TrevorParscal.
Jdforrester-WMF added a project: WMF-deploy-2014-12-17_(1.25wmf13).
Jdforrester-WMF moved this task from Freezer to FY 18-19 Q3/Q4 on the VisualEditor board.Jan 7 2015, 9:20 PM
gerritbot added a project: Patch-For-Review.Jan 21 2015, 2:11 AM
gerritbot subscribed.

Change 186134 had a related patch set uploaded (by Prtksxna):
Fix the highlight color for ButtonSelectWidget and ButtonGroupWidget

https://gerrit.wikimedia.org/r/186134

Patch-For-Review

gerritbot added a comment.Jan 21 2015, 7:21 PM

Change 186134 merged by jenkins-bot:
MediaWiki Theme: Adjust ButtonSelectWidget, ButtonGroupWidget highlights

https://gerrit.wikimedia.org/r/186134

Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Jan 23 2015, 11:32 PM
Jdforrester-WMF edited a custom field.Feb 2 2015, 8:03 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Feb 3 2015, 5:03 PM
Jdforrester-WMF removed a project: Patch-For-Review.Feb 19 2015, 9:36 PM
• Prtksxna mentioned this in rGOJUd829d5349f61: MediaWiki Theme: Adjust ButtonSelectWidget, ButtonGroupWidget highlights.Mar 3 2015, 7:49 PM
Jdforrester-WMF moved this task from Next-up to Reviewing on the OOUI board.Mar 26 2015, 8:56 PM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL