MediaWiki core 'structure' tests are not run for extensions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Dec 17 2014, 4:14 PM

Description

Testing several Mobile related extensions together ( https://integration.wikimedia.org/ci/job/mediawiki-phpunit-integration-hhvm/4/ ), raised tests not passing:

AutoLoaderTest.testAutoLoadConfig
ResourcesTest.testMissingDependencies
ResourcesTest.testUnsatisfiableDependencies

They are caught in core via the 'structure' tests available in tests/phpunit/structure.

On MediaWiki extension, we run the testextension-{hhvm,zend} which invokes:

phpunit --testsuite extensions

The extensions suite defined in tests/phpunit/suite.xml should include the structure directory to have those tests run on extensions.

Details

	Subject	Repo	Branch	Lines +/-
	Run structure tests on extensions	mediawiki/core	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: rMW61a30753a698: Run structure tests on extensions

Event Timeline

hashar created this task.Dec 17 2014, 4:14 PM

hashar raised the priority of this task from to Needs Triage.

hashar updated the task description. (Show Details)

hashar added projects: Continuous-Integration-Infrastructure, MediaWiki-Core-Tests.

hashar changed Security from none to None.

hashar subscribed.

Change 180496 had a related patch set uploaded (by Hashar):
Run structure tests on extensions

https://gerrit.wikimedia.org/r/180496

Patch-For-Review

Jdforrester-WMF subscribed.Dec 17 2014, 5:57 PM

Announced on wikitech https://lists.wikimedia.org/pipermail/wikitech-l/2014-December/079864.html

scfc subscribed.Dec 18 2014, 7:05 AM

Change 180496 merged by jenkins-bot:
Run structure tests on extensions

https://gerrit.wikimedia.org/r/180496

hashar mentioned this in rMW61a30753a698: Run structure tests on extensions.Dec 18 2014, 9:14 AM

Can we mark as closed? Seems to be done to me…

Krinkle closed this task as Resolved.Dec 18 2014, 8:42 PM

Krinkle triaged this task as Medium priority.

Krinkle removed a project: Patch-For-Review.

Krinkle subscribed.

Well it is only going to pass on master branch, the REL branches will need fixes to be backported as well :-(

In T78798#933895, @hashar wrote:

Well it is only going to pass on master branch, the REL branches will need fixes to be backported as well :-(

Do we care?

As long as we maintain them probably. We will soon have a Jenkins job common to core + some tensions, and that job might end up failing when we release new versions of mediawiki.

Jdlrobson subscribed.Dec 18 2014, 11:28 PM

hashar moved this task from Untriaged to Done on the Continuous-Integration-Infrastructure board.Jan 15 2015, 9:41 PM

MediaWiki core 'structure' tests are not run for extensionsClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

MediaWiki core 'structure' tests are not run for extensions
Closed, ResolvedPublic
Actions