Page MenuHomePhabricator

MediaWiki core 'structure' tests are not run for extensions
Closed, ResolvedPublic

Description

Testing several Mobile related extensions together ( https://integration.wikimedia.org/ci/job/mediawiki-phpunit-integration-hhvm/4/ ), raised tests not passing:

AutoLoaderTest.testAutoLoadConfig
ResourcesTest.testMissingDependencies
ResourcesTest.testUnsatisfiableDependencies

They are caught in core via the 'structure' tests available in tests/phpunit/structure.

On MediaWiki extension, we run the testextension-{hhvm,zend} which invokes:

phpunit --testsuite extensions

The extensions suite defined in tests/phpunit/suite.xml should include the structure directory to have those tests run on extensions.

Details

Related Gerrit Patches:
mediawiki/core : masterRun structure tests on extensions

Event Timeline

hashar created this task.Dec 17 2014, 4:14 PM
hashar raised the priority of this task from to Needs Triage.
hashar updated the task description. (Show Details)
hashar changed Security from none to None.
hashar added a subscriber: hashar.

Change 180496 had a related patch set uploaded (by Hashar):
Run structure tests on extensions

https://gerrit.wikimedia.org/r/180496

Patch-For-Review

scfc added a subscriber: scfc.Dec 18 2014, 7:05 AM

Change 180496 merged by jenkins-bot:
Run structure tests on extensions

https://gerrit.wikimedia.org/r/180496

Can we mark as closed? Seems to be done to me…

Krinkle closed this task as Resolved.Dec 18 2014, 8:42 PM
Krinkle triaged this task as Medium priority.
Krinkle removed a project: Patch-For-Review.
Krinkle added a subscriber: Krinkle.

Well it is only going to pass on master branch, the REL branches will need fixes to be backported as well :-(

Well it is only going to pass on master branch, the REL branches will need fixes to be backported as well :-(

Do we care?

As long as we maintain them probably. We will soon have a Jenkins job common to core + some tensions, and that job might end up failing when we release new versions of mediawiki.