LivePreview: Since 1.25wmf12 in 'section=new' mode the section header is not shown
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ricordisamoa
	Dec 18 2014, 2:48 PM

Description

Steps to reproduce:

Enable LivePreview.
Edit a page in 'new section' mode (e.g. https://test.wikipedia.org/w/index.php?title=TestLivePreview&action=edit&section=new&preloadtitle=Header)
Click on "Show preview".
- The section header is not shown in the preview.
Disable LivePreview or JavaScript.
Refresh the page.
Click on "Show preview".
- The section header is now shown in the preview.

Expected Result: The section header should be also shown when using LivePreview.

Details

Subject	Repo	Branch	Lines +/-
ApiParse: Fix parse of new section title	mediawiki/core	master	+32 -10
LivePreview: Support section=new for preview	mediawiki/core	master	+19 -8
ApiParse: Support previewing section=new	mediawiki/core	master	+17 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T41272 Bugs in "Live preview" feature (tracking)
		Resolved		TheDJ	T84877 LivePreview: Since 1.25wmf12 in 'section=new' mode the section header is not shown

Event Timeline

Ricordisamoa created this task.Dec 18 2014, 2:48 PM

Ricordisamoa raised the priority of this task from to Needs Triage.

Ricordisamoa updated the task description. (Show Details)

Ricordisamoa added a project: MediaWiki-JavaScript.

Ricordisamoa changed Security from none to None.

Ricordisamoa subscribed.

Fomafix updated the task description. (Show Details)Dec 18 2014, 3:30 PM

Fomafix subscribed.

Aklapper triaged this task as Medium priority.Dec 19 2014, 3:42 PM

matmarex edited projects, added MediaWiki-Page-editing, JavaScript; removed MediaWiki-JavaScript.Dec 21 2014, 5:19 PM

Ltrlg subscribed.Mar 7 2015, 5:01 PM

The problem is that the api preview result is different from the Preview action. It seems the API does not insert the title into the wikitext, to be parsed and only shows the edit summary preview.

We should probably add the "section=new" option to the parse api, as we have in the edit api...
Alternatively, we can just hardcode it in the live preview module, but that doesn't seem long term sustainable to me, especially with the new link anchor, and possibility of moving from <h2> to a div/header wrapped h2.

Change 195695 had a related patch set uploaded (by TheDJ):
ApiParse: Support previewing section=new

https://gerrit.wikimedia.org/r/195695

gerritbot added a project: Patch-For-Review.Mar 10 2015, 10:39 PM

Change 196443 had a related patch set uploaded (by TheDJ):
LivePreview: Support section=new for preview

https://gerrit.wikimedia.org/r/196443

Change 195695 merged by jenkins-bot:
ApiParse: Support previewing section=new

https://gerrit.wikimedia.org/r/195695

Ricordisamoa awarded a token.Mar 17 2015, 11:08 AM

Change 198092 had a related patch set uploaded (by TheDJ):
ApiParse: Fix parse of new section title

https://gerrit.wikimedia.org/r/198092

TheDJ claimed this task.Mar 20 2015, 7:14 AM

Anomie mentioned this in rMWc223e0bfb098: ApiParse: Support previewing section=new.Mar 23 2015, 3:51 PM