I did this for the Growth team extensions earlier, so I'm familiar with what to grep for.
See also https://jquery.com/upgrade-guide/1.9/ and T84996: Buttons requiring a rationale on Curation toolbar appear to be broken.
I did this for the Growth team extensions earlier, so I'm familiar with what to grep for.
See also https://jquery.com/upgrade-guide/1.9/ and T84996: Buttons requiring a rationale on Curation toolbar appear to be broken.
Moodbar has live() calls in modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js
With jquery.migrate loaded (core commit 4882249), PageTriage warns:
JQMIGRATE: jQuery.fn.andSelf() replaced by jQuery.fn.addBack() JQMIGRATE: jQuery.fn.attr('checked') may use property instead of attribute JQMIGRATE: $(html) HTML strings must start with '<' character
but it seems to work OK.
I can't find either in any version of PageTriage, so this probably came from something else. andSelf is actually not used in any of the extensions (but I didn't check past history for all of them).
Okay, these are all the issues I found by going through the 1.9 upgrade guide (that is the only guide there is so far, although we're now at 1.11). I'm not listing the ones I checked/grepped where there was no issue (but I have detailed notes if anyone wants more info), but I've included brief notes where relevant.
All the action items below should have associated tasks (the root for the fixes is T85506: Update extensions maintained by Collaboration team for jQuery 1.9 changes). The audit itself is now done.
.live - As S said, multiple calls in MoodBar: https://phabricator.wikimedia.org/T85300
.add - This was hard to analyze, but as far as I can tell, it looks okay.
Order of triggered "focus" events
jQuery(htmlString) versus jQuery(selectorString)
I also checked for delegate as a bonus. It's not actually deprecated yet, but it's "superseded". There are only two places where it's used, in the version we use of backbone.js (a third-party library) and MoodBar. We can change the MoodBar one when we fix the 'hover' string (T85512) (it's in the same place)