Maniphest T85509

Fix incorrect deserialization of HTML in WikiLove
Closed, ResolvedPublic
Actions

Assigned To

• Mattflaschen-WMF

Authored By

	• Mattflaschen-WMF
	Dec 30 2014, 4:28 AM

Tags

Referenced Files

None

Subscribers

Jdforrester-WMF

• Mattflaschen-WMF

View All 9 Subscribers

Description

This is related to jQuery 1.9's change in how HTML is recognized by the $() function.

$.wikiLove.openDialog in ext.wikiLove.core.js has HTML that is deserialized the old way, and does not start with a <.

Details

	Subject	Repo	Branch	Lines +/-
	Update HTML deserialization to meet jQuery 1.9+ requirements	mediawiki/extensions/WikiLove	master	+1 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Krinkle	T46740 Upgrade jQuery from 1.8.x to 1.11.x
		Resolved		None	T67399 Don't use deprecated features removed in jQuery 1.9
		Resolved		• Mattflaschen-WMF	T85506 Update extensions maintained by Collaboration team for jQuery 1.9 changes
		Resolved		• Mattflaschen-WMF	T85509 Fix incorrect deserialization of HTML in WikiLove

Event Timeline

• Mattflaschen-WMF created this task.Dec 30 2014, 4:28 AM

• Mattflaschen-WMF raised the priority of this task from to High.

• Mattflaschen-WMF updated the task description. (Show Details)

• Mattflaschen-WMF added projects: Collaboration-Team-Triage, WikiLove.

• Mattflaschen-WMF added subscribers: Aklapper, Unknown Object (MLST), greg and 6 others.

• Mattflaschen-WMF mentioned this in T85022: Audit deployed Collaboration team extensions for jQuery 1.11 upgrade issues.Dec 30 2014, 5:03 AM

Nikerabbit unsubscribed.Dec 30 2014, 8:05 AM

Ricordisamoa subscribed.Jan 12 2015, 11:31 PM

Krinkle unsubscribed.Jan 17 2015, 1:37 AM

• Mattflaschen-WMF claimed this task.Jan 29 2015, 10:31 PM

• Mattflaschen-WMF edited projects, added Collaboration-Team-Sprint-P-2015-02-11/q3; removed Collaboration-Team-Triage.

• Mattflaschen-WMF set Security to None.

Change 187863 had a related patch set uploaded (by Mattflaschen):
Update HTML deserialization to meet jQuery 1.9 requirements

https://gerrit.wikimedia.org/r/187863

Patch-For-Review

• Mattflaschen-WMF moved this task from Sprint P - ends Feb 11 to Code Review on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Jan 31 2015, 2:23 AM

Nemo_bis unsubscribed.Feb 1 2015, 3:38 PM

matthiasmullie moved this task from Code Review to Product Review on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Feb 2 2015, 11:26 PM

Change 187863 merged by jenkins-bot:
Update HTML deserialization to meet jQuery 1.9 requirements

https://gerrit.wikimedia.org/r/187863

• Mattflaschen-WMF mentioned this in rEWLO76205e682702: Update HTML deserialization to meet jQuery 1.9+ requirements.Feb 3 2015, 9:33 PM

• DannyH closed this task as Resolved.Feb 3 2015, 11:57 PM

• DannyH moved this task from Product Review to Done on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.

• DannyH subscribed.

Diffusion mentioned this in rMEXTbe9e5ed05126: Updated mediawiki/extensions Project: mediawiki/extensions/WikiLove….Mar 11 2015, 6:25 AM