Page MenuHomePhabricator
Create Task
Maniphest T85531

LivePreview: Preview of a redirect is not shown as a redirect
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

Actual Result:

  • The redirect target is shown but the arrow before is missing.

Details

SubjectRepoBranchLines +/-
LivePreview: Wrap content preview with mw-content-*mediawiki/coremaster+12 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

Fomafix created this task.Dec 30 2014, 4:52 PM
Fomafix raised the priority of this task from to Medium.
Fomafix updated the task description. (Show Details)
Fomafix added a subtask: T41272: Bugs in "Live preview" feature (tracking).
Fomafix subscribed.
Aklapper lowered the priority of this task from Medium to Low.Dec 30 2014, 5:40 PM
Aklapper added projects: MediaWiki-Page-editing, DataValues-JavaScript.
Aklapper set Security to None.
Umherirrender edited projects, added JavaScript; removed DataValues-JavaScript.Dec 30 2014, 5:50 PM
matmarex subscribed.Dec 30 2014, 5:54 PM

Hmm. We should associate the mediawiki.action.view.redirectPage module with the redirect Content object, rather than adding it when the page is viewed.

…but we already do, in WikitextContent. Why does this not work? Huh.

Fomafix added a comment.Dec 30 2014, 6:15 PM

The wrapping

<div class="mw-content-ltr" dir="ltr" lang="en">...</div>

is missing.

Fomafix claimed this task.Dec 30 2014, 10:01 PM
gerritbot added a project: Patch-For-Review.Dec 30 2014, 10:04 PM

Change 182293 had a related patch set uploaded (by Gerrit Patch Uploader):
mediawiki.action.edit.preview: Wrap content preview with mw-content-*

https://gerrit.wikimedia.org/r/182293

Patch-For-Review

Fomafix removed a subtask: T41272: Bugs in "Live preview" feature (tracking).Jan 26 2015, 9:57 AM
Fomafix added a parent task: T41272: Bugs in "Live preview" feature (tracking).
gerritbot subscribed.Feb 28 2015, 2:47 PM

Change 182293 merged by jenkins-bot:
LivePreview: Wrap content preview with mw-content-*

https://gerrit.wikimedia.org/r/182293

Fomafix mentioned this in rMW12e031a99d5b: LivePreview: Wrap content preview with mw-content-*.Feb 28 2015, 2:48 PM
TheDJ closed this task as Resolved.Feb 28 2015, 3:50 PM
TheDJ removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits