Page MenuHomePhabricator
Create Task
Maniphest T85947

Convert operations/mediawiki-config to use composer for phpunit and php linting
Closed, ResolvedPublic
Actions

Description

See https://www.mediawiki.org/wiki/Continuous_integration/Test_entry_points#PHP for an example

Details

SubjectRepoBranchLines +/-
Add "composer test" command to lint files and run testsoperations/mediawiki-configmaster+17 -7
build: Update PHPUnit from 3.7 to 4.8, add phplint to composer-testoperations/mediawiki-configmaster+833 -86
Replace -phpunit with -composer-hhvm-jessie for operations/mediawiki-configintegration/configmaster+7 -32
build: require-dev phpunit in composer.jsonoperations/mediawiki-configmaster+424 -3
Add operations-mw-config-composer-jessie jobintegration/configmaster+19 -3
Add fetch-composer-dev.sh script (derived from mw-fetch-composer-dev.sh)integration/jenkinsmaster+9 -0
Experimental operations-mw-config-composer jobintegration/configmaster+3 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Jan 6 2015, 8:04 PM
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added a project: Continuous-Integration-Infrastructure.
Legoktm subscribed.
Legoktm mentioned this in T76621: Set up composer validate job for operations/mediawiki-config.Jan 6 2015, 8:21 PM
Krinkle subscribed.Jan 6 2015, 8:25 PM
hashar subscribed.Jan 7 2015, 3:11 PM
Legoktm claimed this task.Feb 7 2015, 12:09 AM
gerritbot added a project: Patch-For-Review.Feb 7 2015, 12:59 AM
gerritbot subscribed.

Change 189148 had a related patch set uploaded (by Legoktm):
Add "composer test" command to lint files and run tests

https://gerrit.wikimedia.org/r/189148

Patch-For-Review

gerritbot added a comment.Feb 9 2015, 2:36 PM

Change 189482 had a related patch set uploaded (by Hashar):
Experimental operations-mw-config-composer job

https://gerrit.wikimedia.org/r/189482

Patch-For-Review

gerritbot added a comment.Feb 9 2015, 2:43 PM

Change 189482 merged by jenkins-bot:
Experimental operations-mw-config-composer job

https://gerrit.wikimedia.org/r/189482

hashar mentioned this in rCICF247528e5d6c9: Experimental operations-mw-config-composer job.Feb 9 2015, 2:43 PM
Liuxinyu970226 subscribed.Feb 13 2015, 8:51 AM
hashar triaged this task as Medium priority.Feb 20 2015, 3:35 PM
hashar moved this task from Untriaged to In-progress on the Continuous-Integration-Infrastructure board.
hashar set Security to None.
Legoktm added a subtask: T92605: Come up with non sucky solution for running "composer test" on repos that have vendor/ checked in.Apr 20 2015, 3:54 AM
Paladox subscribed.Feb 17 2016, 11:16 AM

I think @Krinkle made this possible but I'm not sure weather you have to use mediawiki/core to override which version to use.

Krinkle unsubscribed.Feb 23 2016, 4:49 PM
hashar edited projects, added Continuous-Integration-Config; removed Continuous-Integration-Infrastructure.Mar 10 2016, 2:24 PM
hashar moved this task from Backlog to Repo setup on the Continuous-Integration-Config board.
hashar mentioned this in T115713: Clone mediawiki into mediawiki-config when running test's via jenkins .Nov 10 2016, 4:21 PM
Krinkle added a comment.Jan 6 2017, 4:22 AM

I'll take this on further and try use the composer-fetch-dev script. That way we will still be testing with the committed version of production deps, which can otherwise mask or cause problems.

Krinkle claimed this task.Jan 6 2017, 4:22 AM
gerritbot added a comment.Jan 6 2017, 4:38 AM

Change 325055 had a related patch set uploaded (by Krinkle):
build: require-dev phpunit in composer.json

https://gerrit.wikimedia.org/r/325055

gerritbot added a comment.Jan 6 2017, 4:41 AM

Change 330842 had a related patch set uploaded (by Krinkle):
Add fetch-composer-dev.sh script (derived from mw-fetch-composer-dev.sh)

https://gerrit.wikimedia.org/r/330842

gerritbot added a comment.Jan 6 2017, 4:45 AM

Change 330843 had a related patch set uploaded (by Krinkle):
Add operations-mw-config-composer-jessie job

https://gerrit.wikimedia.org/r/330843

gerritbot added a comment.Jan 6 2017, 4:49 AM

Change 330842 merged by jenkins-bot:
Add fetch-composer-dev.sh script (derived from mw-fetch-composer-dev.sh)

https://gerrit.wikimedia.org/r/330842

gerritbot added a comment.Jan 6 2017, 4:51 AM

Change 330843 merged by jenkins-bot:
Add operations-mw-config-composer-jessie job

https://gerrit.wikimedia.org/r/330843

gerritbot added a comment.Jan 6 2017, 10:57 PM

Change 325055 had a related patch set uploaded (by Krinkle):
build: require-dev phpunit in composer.json

https://gerrit.wikimedia.org/r/325055

gerritbot added a comment.Jan 6 2017, 11:48 PM

Change 331093 had a related patch set uploaded (by Krinkle):
build: Update PHPUnit from 3.7 to 4.8, add phplint to composer-test

https://gerrit.wikimedia.org/r/331093

gerritbot added a comment.Jan 7 2017, 12:20 AM

Change 331099 had a related patch set uploaded (by Krinkle):
Replace -phpunit with -composer-hhvm-jessie for operations/mediawiki-config

https://gerrit.wikimedia.org/r/331099

gerritbot added a comment.Jan 7 2017, 12:57 AM

Change 325055 merged by jenkins-bot:
build: require-dev phpunit in composer.json

https://gerrit.wikimedia.org/r/325055

gerritbot added a comment.Jan 10 2017, 11:04 PM

Change 331093 merged by jenkins-bot:
build: Update PHPUnit from 3.7 to 4.8, add phplint to composer-test

https://gerrit.wikimedia.org/r/331093

Krinkle closed subtask T92605: Come up with non sucky solution for running "composer test" on repos that have vendor/ checked in as Resolved.Jan 10 2017, 11:05 PM
gerritbot added a comment.Jan 10 2017, 11:06 PM

Change 331099 merged by jenkins-bot:
Replace -phpunit with -composer-hhvm-jessie for operations/mediawiki-config

https://gerrit.wikimedia.org/r/331099

Krinkle closed this task as Resolved.Jan 10 2017, 11:08 PM
Liuxinyu970226 unsubscribed.Jan 10 2017, 11:59 PM
Stashbot subscribed.Jan 11 2017, 2:09 PM

Mentioned in SAL (#wikimedia-operations) [2017-01-11T14:09:08Z] <hashar@tin> Synchronized composer.lock: build: Update PHPUnit from 3.7 to 4.8, add phplint to composer-test - T85947 (duration: 00m 55s)

Stashbot added a comment.Jan 11 2017, 2:10 PM

Mentioned in SAL (#wikimedia-operations) [2017-01-11T14:10:05Z] <hashar@tin> Synchronized composer.json: build: Update PHPUnit from 3.7 to 4.8, add phplint to composer-test - T85947 (duration: 00m 45s)

hashar added a comment.Jan 11 2017, 8:38 PM

Deployed on the cluster during the European SWAT. Definitely a noop as expected :-}

gerritbot added a comment.Jan 11 2017, 10:59 PM

Change 189148 abandoned by Reedy:
Add "composer test" command to lint files and run tests

Reason:
I9583a4574df4e6c3e7b41d8c4814e091c6498115

https://gerrit.wikimedia.org/r/189148

Krinkle added a parent task: T115713: Clone mediawiki into mediawiki-config when running test's via jenkins .Jan 12 2017, 8:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits