Maniphest T85948

Text that was added to a slug immediately vanishes when the cursor is placed in another slug
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Mooeypoo
	Jan 6 2015, 8:13 PM

Tags

Referenced Files

	F29727: slugs_testing.mov
	Jan 19 2015, 11:32 PM

Subscribers

Jdforrester-WMF

Description

List Item

Reproduce:

Go to this article as an example (it starts with multiple block images) https://www.mediawiki.org/wiki/User:MSchottlender-WMF/VE_SlugText
Go into the slug at the very top and write some sentence.
Click on the slug right under the new line that was just entered.

Result: The initial line in the initial slug vanished.

Interesting discovery: If you then go to "Save page" and look at "Review your changes" the vanished text appears in the diff, and will be saved - but it is gone from view until VE is reloaded after save.

Ubuntu 14.04; Chrome Version 39.0.2171.95 (64-bit) and Firefox

Details

	Subject	Repo	Branch	Lines +/-
	Unwrap slug wrappers when converting to a real paragraph	VisualEditor/VisualEditor	master	+5 -0

Customize query in gerrit

Related Objects

Mentioned In: rGVED916d1b9c82d6: Unwrap slug wrappers when converting to a real paragraph

Event Timeline

Mooeypoo created this task.Jan 6 2015, 8:13 PM

Mooeypoo raised the priority of this task from to Needs Triage.

Mooeypoo updated the task description. (Show Details)

Mooeypoo added projects: VisualEditor-ContentEditable, VisualEditor.

Mooeypoo subscribed.

Holy crap this is real. No clue what's happening here. Maybe the slug animation code is bad?

Mooeypoo added a comment.Jan 6 2015, 11:58 PM

This comment was removed by Mooeypoo.

Jdforrester-WMF triaged this task as Unbreak Now! priority.Jan 7 2015, 9:28 PM

Jdforrester-WMF set Security to None.

Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.

Change 185193 had a related patch set uploaded (by Esanders):
Unwrap slug wrappers when converting to a real paragraph

https://gerrit.wikimedia.org/r/185193

Patch-For-Review

Jdforrester-WMF assigned this task to Esanders.Jan 15 2015, 4:43 PM

Jdforrester-WMF moved this task from External and Administrivia to Blocked on the VisualEditor board.

Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Jan 16 2015, 7:26 PM

Change 185193 merged by jenkins-bot:
Unwrap slug wrappers when converting to a real paragraph

https://gerrit.wikimedia.org/r/185193

(Needs confirmation testing once Beta Labs finally updates.)

Jdforrester-WMF closed this task as Resolved.Jan 18 2015, 5:23 PM

Jdforrester-WMF edited projects, added WMF-deploy-2015-02-04_(1.25wmf16); removed Patch-For-Review.

Seems to be fixed in beta.
I've attached a video(rather a big one - ~9MB)

slugs_testing.mov8 MBDownload

to illustrate the issue on https://www.mediawiki.org/w/index.php?title=User:MSchottlender-WMF/VE_SlugText&veaction=edit. The same issue is happening in test2.

Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Jan 23 2015, 11:32 PM

Jdforrester-WMF edited a custom field.Jan 23 2015, 11:45 PM

Jdforrester-WMF updated the task description. (Show Details)Feb 2 2015, 7:37 PM

Jdforrester-WMF edited a custom field.

Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Feb 3 2015, 5:02 PM

• TrevorParscal edited a custom field.Feb 4 2015, 7:09 PM

Etonkovidova added a project: Verified-in-Phase0.Feb 5 2015, 10:36 PM

Etonkovidova added a project: Verified-in-Phase2.Feb 13 2015, 12:00 AM

Jdforrester-WMF mentioned this in rGVED916d1b9c82d6: Unwrap slug wrappers when converting to a real paragraph.Mar 3 2015, 7:37 PM