Page MenuHomePhabricator

PopupWidget callout is oversized in WikimediaUI theme
Open, LowestPublic0 Estimated Story Points

Description

Event Timeline

Esanders created this task.Jan 6 2015, 8:29 PM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: VisualEditor.

The size is intentional; the positioning needs fixing, though.

We need to reduce the size of this callout. It wasn't really designed in context, so now that we have context we can finally properly adjust it. I think it's about 2x too big.

Jdforrester-WMF triaged this task as Medium priority.Jan 9 2015, 10:46 PM
Restricted Application added a project: UI-Standardization. · View Herald TranscriptFeb 14 2017, 5:51 AM
Volker_E renamed this task from PopupWidget callout is oversized in MW theme and overlaps text to PopupWidget callout is oversized in MW theme.Feb 14 2017, 5:52 AM
Volker_E lowered the priority of this task from Medium to Lowest.

“Overlapping text” is in the mean time fixed.

@Pginer-WMF Do you think the anchor/callout/triangle is oversized in MediaWiki theme with its base side width of 10px. I've always thought it's a tad too prominent and should probably be reduced to 8px.
In the OOjs UI documentation Apex theme is still featured as default theme, it features a 7px base side width.
I propose to go for a 8px base side width.

Current (as of v0.19.4):

8px:

Jdforrester-WMF set the point value for this task to 0.

WFM.

@Pginer-WMF Do you think the anchor/callout/triangle is oversized in MediaWiki theme with its base side width of 10px. I've always thought it's a tad too prominent and should probably be reduced to 8px.

The proposals look good to me, but I wanted to point out that there are different measures involved here that we may want to specify and make conscious decisions about: length of the sides, angles, and separation from the object. For example, if you aim at a 8px vertical rithm (maybe we don't need it here), the triangle in your example despite using an 8px side as a base is going to break the rithm because of Pythagoras.

Volker_E moved this task from Backlog to Next-up on the OOUI board.Apr 7 2017, 12:42 AM
Jdforrester-WMF renamed this task from PopupWidget callout is oversized in MW theme to PopupWidget callout is oversized in WikimediaUI theme.May 20 2017, 8:23 AM
Volker_E moved this task from Unsorted to OOUI on the UI-Standardization board.Aug 15 2017, 9:39 PM