All of deployment-prep has puppetmaster set to deployment-salt, except for deployment-mx which is set to itself. There's also a local patch in its puppetmaster, with unknown authorship (just says root).
Description
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T53494 Use Beta cluster as a true canary for code deployments (epic) | |||
Open | None | T87220 Minimize infrastructure differences between Beta Cluster and production | |||
Resolved | yuvipanda | T86575 deployment-mx is its own puppetmaster |
Event Timeline
Ccing Jeff Green
It should be possible to point it back to the deployment-salt puppet master. Never tried though :(
Note: all patches applied on puppetmaster must be sent to Gerrit first then cherry picked in /var/lib/git/operations/puppet . That is the only way to track who is doing what and when on a shared infrastructure.
We need to test mx functionality, as part of bounce handler testing, so we need role::mail::mx which conflicts with labs standard instance config .
The local change in question is:
class standard {
#include role::mail::sender # disabled b/c conflicts with role::mail::mx
I don't know of a way to do this without breaking other labs stuff.
I think the underlying problem (not include role::mail::sender) is fixable by hiera; this would solve a similar situation with tools-mail where we need a different exim package for LDAP lookups as well.
Change 186891 had a related patch set uploaded (by Yuvipanda):
Make standard class's exim including behavior configurable
Change 186891 merged by Yuvipanda:
Make standard class's exim including behavior configurable
That didn't actually work yet :) Me and Joe are looking into it. After that I'll need to set the param in hiera for that instance and switch it to deployment-salt, and then hope that it doesn't fail more.
Change 187318 had a related patch set uploaded (by Yuvipanda):
beta: Disable standard mail sender on deployment-mx
Change 187318 merged by Yuvipanda:
beta: Disable standard mail sender on deployment-mx