Page MenuHomePhabricator

Default to not performing sanity checks
Closed, ResolvedPublic8 Estimated Story Points

Description

Seen during VE load. What in the name of all that is holy is going on here?

wtf.png (2×1 px, 988 KB)

Event Timeline

ori raised the priority of this task from to Needs Triage.
ori updated the task description. (Show Details)
ori added subscribers: ori, Catrope, Krinkle.

Notes from discussing this w/Roan:

  • The reason we call oo.copy as part of ve.init.mw.Target.startSanityCheck is that we can't perform a sanity-check once the user has started editing the page.
  • The idea was to stash a clean copy of the DOM and then sanity-check roundtripping against that.
  • Instead of doing that, it might be cheaper to just prevent the user from touching the DOM until it has been sanity-check. If we do that, then we don't need to stash a copy.
ori set Security to None.
Jdforrester-WMF raised the priority of this task from High to Unbreak Now!.Jan 20 2015, 9:10 PM
gerritbot added a subscriber: gerritbot.

Change 186100 had a related patch set uploaded (by Catrope):
[WIP] Make sanity check synchronous

https://gerrit.wikimedia.org/r/186100

Patch-For-Review

ori renamed this task from ve.init.mw.Target.startSanityCheck needs a sanity-check to Default to not performing sanity checks.Feb 17 2015, 11:28 PM

Per discussion with Roan and James on 17-Feb-2015, we are going to stop running the sanity check on every run. We'll keep the code for now, but we'll hide it behind a magic query parameter.

Change 191233 had a related patch set uploaded (by Catrope):
Remove the sanity check

https://gerrit.wikimedia.org/r/191233

Patch-For-Review

Change 191233 merged by jenkins-bot:
Remove the sanity check

https://gerrit.wikimedia.org/r/191233

Change 186100 abandoned by Jforrester:
[WIP] Make sanity check synchronous

Reason:
Irrelevant now.

https://gerrit.wikimedia.org/r/186100