Page MenuHomePhabricator
Create Task
Maniphest T87574

Wrong time parsing of ISO dates with day 00
Closed, ResolvedPublic
Actions

Description

2015-01-00 is currently parsed as "1 January 2015 minus 1 day" and becomes "31 December 2014". Should become "January 2015" w/o day instead.

Details

SubjectRepoBranchLines +/-
Add ISO time strings to Lib\TimeParser testsmediawiki/extensions/Wikibasemaster+28 -8
Update DataValues Time to 0.7.0mediawiki/extensions/Wikibasemaster+38 -669
Add fail-safe for YYYY-00-00 to DateTimeParsermediawiki/extensions/Wikibasemaster+21 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

thiemowmde created this task.Jan 26 2015, 2:25 PM
thiemowmde claimed this task.
thiemowmde raised the priority of this task from to Medium.
thiemowmde updated the task description. (Show Details)
thiemowmde added a project: MediaWiki-extensions-WikibaseRepository.
thiemowmde subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2015, 2:25 PM
Lydia_Pintscher set Security to None.Jan 26 2015, 3:24 PM
Lydia_Pintscher added a project: Wikidata.
Lydia_Pintscher added subscribers: adrianheine, daniel.
thiemowmde added a project: Patch-For-Review.Jan 26 2015, 4:57 PM

https://github.com/DataValues/Time/pull/27

gerritbot subscribed.Jan 26 2015, 5:12 PM

Change 186791 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Add ISO time strings to Lib\TimeParser tests

https://gerrit.wikimedia.org/r/186791

Patch-For-Review

Tobi_WMDE_SW added a parent task: T87764: Bugs related to time datatype (tracking).Jan 28 2015, 2:19 PM
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Feb 16 2015, 5:27 PM
gerritbot added a comment.Feb 23 2015, 1:14 PM

Change 192306 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Add fail-safe for YYYY-00-00 to DateTimeParser

https://gerrit.wikimedia.org/r/192306

Patch-For-Review

gerritbot added a comment.Mar 2 2015, 1:03 PM

Change 192306 merged by jenkins-bot:
Add fail-safe for YYYY-00-00 to DateTimeParser

https://gerrit.wikimedia.org/r/192306

thiemowmde mentioned this in rEWBA9d9e5c9c9b49: Add fail-safe for YYYY-00-00 to DateTimeParser.Mar 2 2015, 1:03 PM
Diffusion mentioned this in rMEXT76d996af43a0: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Mar 11 2015, 6:27 AM
thiemowmde added a comment.Mar 13 2015, 6:50 PM

I tried to split https://github.com/DataValues/Time/pull/27 to make it easier to review:

Tobi_WMDE_SW added a project: § Wikidata-Sprint-2015-03-11.Mar 17 2015, 10:15 AM
Tobi_WMDE_SW moved this task from Backlog to Review on the § Wikidata-Sprint-2015-03-11 board.
Tobi_WMDE_SW mentioned this in T88437: figure out and fix current state of time storage and display.Mar 17 2015, 10:28 AM
JanZerebecki subscribed.Mar 20 2015, 10:49 PM

This needs a new release of https://github.com/DataValues/Time .

JanZerebecki moved this task from Review to Doing on the § Wikidata-Sprint-2015-03-11 board.Mar 20 2015, 10:49 PM
Lydia_Pintscher moved this task from Doing to Review on the § Wikidata-Sprint-2015-03-11 board.Mar 24 2015, 1:32 PM
Tobi_WMDE_SW added a project: § Wikidata-Sprint-2015-03-24.Mar 24 2015, 1:32 PM
Tobi_WMDE_SW moved this task from Backlog to Doing on the § Wikidata-Sprint-2015-03-24 board.
Tobi_WMDE_SW subscribed.

https://github.com/DataValues/Time/pull/27 still needs to be merged

JanZerebecki added a comment.Mar 24 2015, 1:35 PM

Still open:
https://github.com/DataValues/Time/pull/27
https://gerrit.wikimedia.org/r/#/c/186791/ which needs a release and dependency update of DataValues/Time after the above is merged

JanZerebecki moved this task from Review to Doing on the § Wikidata-Sprint-2015-03-11 board.Mar 24 2015, 1:35 PM
JanZerebecki moved this task from Doing to Review on the § Wikidata-Sprint-2015-03-11 board.
Accurimbono subscribed.Apr 4 2015, 11:05 AM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-04-07.Apr 7 2015, 12:47 PM
Tobi_WMDE_SW moved this task from Backlog to Review on the Wikidata-Sprint-2015-04-07 board.
daniel added a comment.Apr 10 2015, 2:13 PM

I merged the pull request on github, and gave a +2 on gerrit. But before the change can be merged, we need a new release of DataValues/Time, it seems.

daniel reassigned this task from thiemowmde to Tobi_WMDE_SW.Apr 10 2015, 2:16 PM
daniel moved this task from Review to Backlog on the Wikidata-Sprint-2015-04-07 board.
daniel moved this task from Backlog to Done on the Wikidata-Sprint-2015-04-07 board.Apr 17 2015, 2:37 PM
daniel moved this task from Done to Backlog on the Wikidata-Sprint-2015-04-07 board.
daniel moved this task from Backlog to Review on the Wikidata-Sprint-2015-04-07 board.Apr 20 2015, 5:57 PM
daniel added a comment.Apr 20 2015, 6:00 PM

0.7.0 of DataValues/Time was released.
Pending review of https://gerrit.wikimedia.org/r/#/c/205267/

gerritbot added a comment.Apr 20 2015, 6:00 PM

Change 205267 had a related patch set uploaded (by Daniel Kinzler):
Update DataValues Time to 0.7.0

https://gerrit.wikimedia.org/r/205267

daniel added a subtask: T96137: Release and use data-values/time 0.7.Apr 20 2015, 6:01 PM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-04-21.Apr 21 2015, 12:54 PM
Tobi_WMDE_SW moved this task from Backlog to Review on the Wikidata-Sprint-2015-04-21 board.
gerritbot added a comment.Apr 21 2015, 1:36 PM

Change 205267 merged by jenkins-bot:
Update DataValues Time to 0.7.0

https://gerrit.wikimedia.org/r/205267

Diffusion mentioned this in rMEXT5105c931e938: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Apr 21 2015, 1:36 PM
thiemowmde mentioned this in rEWBA98caaeb782a4: Update DataValues Time to 0.7.0.Apr 21 2015, 1:36 PM
Tobi_WMDE_SW closed this task as Resolved.Apr 21 2015, 3:40 PM
Tobi_WMDE_SW closed subtask T96137: Release and use data-values/time 0.7 as Resolved.
Tobi_WMDE_SW moved this task from Review to Done on the Wikidata-Sprint-2015-04-21 board.
gerritbot added a comment.Apr 21 2015, 5:37 PM

Change 186791 merged by jenkins-bot:
Add ISO time strings to Lib\TimeParser tests

https://gerrit.wikimedia.org/r/186791

thiemowmde mentioned this in rMEXT354ac0222552: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Apr 21 2015, 5:37 PM
thiemowmde mentioned this in rEWBAf8d4e4691a50: Add ISO time strings to Lib\TimeParser tests.
daniel moved this task from Review to Done on the Wikidata-Sprint-2015-04-07 board.Apr 22 2015, 8:55 AM
Jc3s5h subscribed.Jun 16 2015, 2:05 PM
thiemowmde mentioned this in T104862: [Bug] Date input parses YYYY MM DD as CURDAY CURMONTH YYYY or not at all.Jul 8 2015, 8:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL