Page MenuHomePhabricator
Create Task
Maniphest T88152

Cite: 'Autofill from URL' initially shows Basic as a type for inserted citation in context menu, then corrects when re-selected
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. In VE insert 'Autofill from URL' - the inserted citation will display Basic type after Insert.
  2. Hover over the inserted citation - the type will be changed to Website
    Basic_reference_Website.mov6 MBDownload
    .

Details

SubjectRepoBranchLines +/-
Refactor Citoid extension as an inspectormediawiki/extensions/Citoidmaster+588 -335
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Jan 30 2015, 8:45 PM
Etonkovidova raised the priority of this task from to Medium.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added a project: VisualEditor.
Etonkovidova subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2015, 8:45 PM
Jdforrester-WMF renamed this task from Cite: 'Autofill from URL' shows Basic as a type for inserted citation to Cite: 'Autofill from URL' initially shows Basic as a type for inserted citation in context menu, then corrects when re-selected.Jan 31 2015, 2:11 AM
Jdforrester-WMF added projects: Citoid, VisualEditor-MediaWiki-References.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.
Krenair subscribed.Jan 31 2015, 7:02 AM
Mvolz moved this task from Backlog to Extension on the Citoid board.Feb 7 2015, 2:47 PM
Mvolz added a subscriber: • TrevorParscal.Feb 10 2015, 6:14 PM
Mvolz subscribed.Feb 10 2015, 6:17 PM

Trevor; at KIT they said you were changing how this was done soon?

Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Feb 11 2015, 10:52 PM
Jdforrester-WMF edited a custom field.Feb 17 2015, 12:50 AM
gerritbot added a project: Patch-For-Review.Feb 17 2015, 2:44 AM
gerritbot subscribed.

Change 190973 had a related patch set uploaded (by Mooeypoo):
Refactor Citoid extension as an inspector

https://gerrit.wikimedia.org/r/190973

Patch-For-Review

Mooeypoo claimed this task.Feb 17 2015, 7:29 PM
Jdforrester-WMF moved this task from TR6: Visual diffs to Blocked on the VisualEditor board.Feb 17 2015, 8:13 PM
Jdforrester-WMF moved this task from Nominated to Accepted on the VisualEditor 2014/15 Q3 blockers board.Feb 18 2015, 4:19 PM
gerritbot added a comment.Mar 9 2015, 10:02 PM

Change 190973 merged by jenkins-bot:
Refactor Citoid extension as an inspector

https://gerrit.wikimedia.org/r/190973

Mooeypoo mentioned this in rECEXef8fc7fa8f7c: Refactor Citoid extension as an inspector.Mar 9 2015, 10:03 PM
Jdforrester-WMF closed this task as Resolved.Mar 9 2015, 10:03 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-03-11_(1.25wmf21); removed Patch-For-Review.
Jdforrester-WMF moved this task from Accepted to Done on the VisualEditor 2014/15 Q3 blockers board.
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Mar 10 2015, 4:15 PM
Etonkovidova added a comment.Mar 10 2015, 8:57 PM

Re-checked in betalabs for a new re-designed dialog citation inspector - all citation entered via "Autofill citations by URL or DOI" are of Website type.

Diffusion mentioned this in rMEXT30cbaf4892c4: Updated mediawiki/extensions Project: mediawiki/extensions/Citoid….Mar 11 2015, 6:28 AM
Mvolz added a comment.Mar 11 2015, 3:58 PM

@Etonkovidova : Did you try a nytimes link? I just did and it came out as "news". When we can't determine the type of a resource, the default type is "website" so sometimes it seems like everything is "web".

If you'd like some guaranteed (pretty much) types for testing, nytimes always comes out as "news", and pubmed links www.ncbi.nlm.nih.gov/pubmed/23555203 as "journal", and imdb links should come out as "Citation" since that's what's in the typemap right now: http://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Citoid-template-type-map.json.

If zotero goes down, then all of those may come out as websites, with the exception of imdb, I think- kind of a moving target as we improve our ability to natively categorise resources instead of relying on zotero and using webpage as a default.

Etonkovidova added a comment.Mar 18 2015, 10:54 PM

Thanks for suggestions! Checked in betalabs and test2

I tried the cases you suggested with 'Add citation' feature:

  • typing nytimes and cliking 'Lookup' - will be saved as Website citation type with URL: http://nytimes - which is most likely another bug
  • www.ncbi.nlm.nih.gov/pubmed/23555203 - will indeed be saved as Journal
  • imdb - will be saved as Website
Mooeypoo added a comment.Mar 19 2015, 12:30 AM
In T88152#1130544, @Etonkovidova wrote:

Thanks for suggestions! Checked in betalabs and test2

I tried the cases you suggested with 'Add citation' feature:

  • typing nytimes and cliking 'Lookup' - will be saved as Website citation type with URL: http://nytimes - which is most likely another bug
  • www.ncbi.nlm.nih.gov/pubmed/23555203 - will indeed be saved as Journal
  • imdb - will be saved as Website

This was fixed by https://gerrit.wikimedia.org/r/#/c/197718/ (merged) see https://phabricator.wikimedia.org/T93005

Etonkovidova added a comment.Mar 19 2015, 7:26 PM

Thanks!
Checked again:
Entering in 'Add citation' nytimes and imdb will return "We couldn't make a citation for you. You can make one by using the full citation dialog." - which is correct behaviour.

Etonkovidova added a project: Verified-in-Phase0.Mar 26 2015, 11:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL