Page MenuHomePhabricator

Disabled button style not right
Closed, ResolvedPublic

Description

#FFF on icon and text
#DDD on button background

  • OOjs UI
  • mediawiki.ui (LESS)

Event Timeline

violetto assigned this task to Prtksxna.
violetto raised the priority of this task from to Needs Triage.
violetto updated the task description. (Show Details)
violetto added a subscriber: violetto.
Prtksxna triaged this task as Medium priority.Feb 8 2015, 8:43 AM
Prtksxna set Security to None.
gerritbot added a subscriber: gerritbot.

Change 189945 had a related patch set uploaded (by Prtksxna):
MediaWiki Theme: Use white icons for disabled buttons

https://gerrit.wikimedia.org/r/189945

Patch-For-Review

Change 189946 had a related patch set uploaded (by Prtksxna):
MediaWiki Theme: Fix background color for disabled buttons

https://gerrit.wikimedia.org/r/189946

Patch-For-Review

Change 189946 merged by jenkins-bot:
MediaWiki Theme: Fix background color for disabled buttons

https://gerrit.wikimedia.org/r/189946

The icon on disabled buttons are still not white, reopening this task.

Change 190996 had a related patch set uploaded (by Prtksxna):
mediawiki.ui: button: Use the correct background color for disabled buttons

https://gerrit.wikimedia.org/r/190996

Patch-For-Review

Change 190996 merged by jenkins-bot:
mediawiki.ui: button: Use the correct background color for disabled buttons

https://gerrit.wikimedia.org/r/190996

matmarex renamed this task from Disabled button color not right to Disabled button style not right.Feb 17 2015, 2:12 PM

Change 189945 merged by jenkins-bot:
MediaWiki Theme: Use white icons for disabled buttons

https://gerrit.wikimedia.org/r/189945

matmarex edited projects, added OOjs-UI-next-release; removed Patch-For-Review.
matmarex removed a subscriber: gerritbot.
matmarex added a subscriber: matmarex.

Should be all fixed now. If you spot any inconsistencies between OOUI and mediawiki.ui, let's put them on T88449.

Thanks, saw the fixes they look great.