Page MenuHomePhabricator

"learn more" link in new task creation is able to destroy the window
Closed, ResolvedPublic

Description

Thanks to the deficiencies of the "learn more" link in https://phabricator.wikimedia.org/maniphest/task/create/ , I just lost a long report I have spent 15 minutes writing.

The link is:

<a href="https://www.mediawiki.org/wiki/Special:MyLanguage/Phabricator/Help#Using_e-mail">learn more</a>

There are two major issues here:

  1. the link shold open in a new tab:
  2. the link is selected as first thing when I press "tab" from the main text area, instead of the "create task" button, which is instead expected due to its blue colour.

The two issues, combined, mean that tab+enter inadvertently exits the window. This, combined with the lack of a warning (is a bug filed?) and with T86463, caused total and irrecoverable destruction of my report.

Event Timeline

Nemo_bis raised the priority of this task from to Needs Triage.
Nemo_bis updated the task description. (Show Details)
Nemo_bis added a project: Phabricator.
Nemo_bis subscribed.
Nemo_bis set Security to None.
Nemo_bis updated the task description. (Show Details)

This comes from T865. It looks like we should require ourselves to test in phab-01 first even for changes that look simple.

I'm sorry to hear that, Nemo_bis. Tab ordering was something I hadn't tested (and I doubt we would have caught this on phab-01, to be honest). The underlying issue is indeed T86463; moving away from a page should /never/ clear that page.

The "create new project" link (weren't we going to remove that?) doesn't have this issue, as it opens a popup in the same web page.

I'll create a patch adding both tabindex="-1" and target="_blank" to the URL, which should solve this issue as long as T86463 isn't fixed. Could someone else upstream that bug to secure.phabricator.org?

gerritbot subscribed.

Change 190186 had a related patch set uploaded (by Merlijn van Deen):
'learn more': exclude from tab order and open in new window

https://gerrit.wikimedia.org/r/190186

Patch-For-Review

Aklapper triaged this task as Medium priority.Feb 12 2015, 12:32 PM

Change 190186 merged by Rush:
'learn more': exclude from tab order and open in new window

https://gerrit.wikimedia.org/r/190186

valhallasw claimed this task.

Seems fixed. Sorry again, @Nemo_bis.

Looks good indeed. Thank you a lot, valhallasw.

This comes from T865.

I suggest to place the e-mail hint after the two butttons. It would solve the Tab issue encountered by @Nemo_bis, and it would make more sense anyway.

@Nnemo: Changing the position of that string would require actual code changes (by moving "aphront-form-caption") and has larger maintenance costs than just overwriting a string (like done for this task) so I'd prefer to avoid that in our instance. However, if there's strong and convincing reasons to move the position of that string these reasons could be presented to upstream.