In T60942#1037747, @Multichill wrote:We have quite a few pywikibot scripts in core (https://git.wikimedia.org/tree/pywikibot%2Fcore.git/HEAD/scripts). Some of these scripts import other scripts. That shouldn't happen. These target scripts should probably be split up in a library part and a script part:
grep "from scripts import" *.py
data_ingestion.py:from scripts import upload
flickrripper.py:from scripts import upload
template.py:from scripts import replaceMost notable one is upload.py
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| [IMPR] Separate scripts and library part | pywikibot/core | master | +501 -484 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Invalid | None | T72936 Important tasks to be solved (tracking) | |||
| Open | Feature | None | T57880 Functionality existing in compat but missing from core (tracking) | ||
| Resolved | droid | T66856 Port various Commons upload bots to core & move to separate repository | |||
| Open | None | T60942 Features to move from scripts to framework (tracking) | |||
| Resolved | Xqt | T89499 Refactor upload.py / move re-usable parts to framework | |||
| Resolved | Xqt | T68561 Add 'upload' method to ImagePage |
Event Timeline
Comment Actions
Change 283422 had a related patch set uploaded (by Xqt):
[IMPR] Separate scripts and library part