Deployment needs to be coordinated with T89428: Flow logging is broken.
Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Backfill moderation (delete, suppress) logging that was dropped | mediawiki/extensions/Flow | master | +110 -2 |
Revisions and Commits
Revisions and Commits
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | EBernhardson | T89428 Flow logging is broken | |||
Resolved | • Mattflaschen-WMF | T89504 Write maintenance script to recover lost moderation logs |
Event Timeline
Comment Actions
I realized when testing this that the dates were wrong. I can think of a couple approaches:
- Use LogEntry->setTimestamp when the revision's date (not really necessary for normal logging, but a general way to deal with this problem).
- Pass an optional timestamp field that is only used for scripts like this (e.g. in the metadata parameter)
I think #1 is cleaner, but I'm open to suggestions.
Comment Actions
Change 191543 had a related patch set uploaded (by Mattflaschen):
WIP: Backfill moderation (delete, suppress) logging that was dropped
Comment Actions
generally we should be setting any timestamp about a revision to match the timestamp within the revision, in additon to being cleaner we have had off by one errors in tests because of the timestamps differing.
Comment Actions
Change 191543 merged by jenkins-bot:
Backfill moderation (delete, suppress) logging that was dropped