Change 190645 had a related patch set uploaded (by Bartosz Dziewoński):
Don't use JavaScript to style first sidebar portlet

https://gerrit.wikimedia.org/r/190645

Patch-For-Review

In the off-chance some user script or style actually depends on .first, I'd feel safer if the skin (vector.php) just adds the class statically.

Or the JS adding .first could be kept as is. This would remove the FOUC while ensuring that any user script/style still works, if that is a concern.

Also, if we want to still give some support to non grade A browsers, then the CSS for .first could be kept as is too.

I think what Bartosz's main concern is, why does that class have to be added with JavaScript, which may incur a rendering delay?

In T89542#1039038, @Edokter wrote:

In the off-chance some user script or style actually depends on .first, I'd feel safer if the skin (vector.php) just adds the class statically.

I searched both the MediaWiki: and User: namespaces and found only one case: ru:User:Зелёный Кошак/edittools.js. So I think we can get rid of it and let this particular user know via a friendly note on his or her talk page. Thoughts?

@Edokter, I meant that maybe we should ensure support for the first class
(by adding it in JS) while still adding in the new sibling selector change.
This would probably take care of the FOUC as well as support user
styles/scripts.
Edokter added a comment.

I think what Bartosz's main concern is, why does that class have to be
added with JavaScript, which may incur a rendering delay?

TASK DETAIL

https://phabricator.wikimedia.org/T89542

REPLY HANDLER ACTIONS

Reply to comment or attach files, or !close, !claim, !unsubscribe or

!assign <username>.

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matmarex, Edokter
Cc: polybuildr, Edokter, gerritbot, matmarex, Krinkle, ori, Aklapper,
GWicke, Jdforrester-WMF, Jay8g

Change 190645 merged by jenkins-bot:
Don't use JavaScript to style first sidebar portlet

https://gerrit.wikimedia.org/r/190645

Change 190699 had a related patch set uploaded (by Ori.livneh):
Don't use JavaScript to style first sidebar portlet

https://gerrit.wikimedia.org/r/190699

Patch-For-Review

Change 190699 merged by jenkins-bot:
Don't use JavaScript to style first sidebar portlet

https://gerrit.wikimedia.org/r/190699

Change 190700 had a related patch set uploaded (by Ori.livneh):
Don't use JavaScript to style first sidebar portlet

https://gerrit.wikimedia.org/r/190700

Patch-For-Review

Change 190700 merged by jenkins-bot:
Don't use JavaScript to style first sidebar portlet

https://gerrit.wikimedia.org/r/190700

@Jdforrester-WMF Yup.

I know we don't support IE6 anymore, but does that mean we should actively break IE6?

What was wrong with my suggestion of simply adding the class statically, thus maintaining compatibility (and skinability I might add), instead of using a 'modern' CSS selector, which otherwise adds no benifit at all?

Is there an issue with not removing the CSS off .first and also leaving in the JS that adds in .first? The FOUC will be handled by using the sibling selector and IE6 will not break because the JS will still be working.

@polybuildr, there should be no issues with doing that, but it won't help
IE 6, because MediaWiki doesn't send any JavaScript to it (it's
blacklisted in /resources/src/startup.js along with a few other outdated
or intentionally limited browsers).