Page MenuHomePhabricator
Create Task
Maniphest T89612

The OOUI hack to prevent scrolling while dialog is open causes pages to scroll when dialog opens
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The OOUI hack to prevent scrolling while dialog is open causes pages to scroll when dialog opens (added in 4d87bde4495e5204b722d2154885f9c127ad30e3 / https://gerrit.wikimedia.org/r/#/c/179598/).

To reproduce:

  • Edit a long page using VisualEditor, such as https://en.wikipedia.org/wiki/Skyfall
  • Scroll far down and open a dialog (for example, for one of the navbox templates; reference list is not a good option because the column highlights in Chrome will mess things up, T52036)
    • Observe that window scrollbar disappears.
    • Observe that the page noticeably scrolls up as it does; in extreme cases, the template itself might go offscreen.

Details

SubjectRepoBranchLines +/-
Compensate for loss of margin when opening modalsoojs/uimaster+14 -5
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Feb 15 2015, 7:15 PM
matmarex assigned this task to Esanders.
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added projects: VisualEditor, VisualEditor-MediaWiki, OOUI.
matmarex subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2015, 7:15 PM
matmarex mentioned this in T89613: "Nested" dialogs (template inside a basic reference) break the OOUI hack to prevent scrolling while dialog is open.Feb 15 2015, 7:16 PM
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Feb 17 2015, 12:12 AM
Jdforrester-WMF triaged this task as Medium priority.Feb 17 2015, 12:16 AM
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from TR6: Visual diffs to Blocked on the VisualEditor board.Feb 17 2015, 7:40 PM
Jdforrester-WMF moved this task from Backlog to Doing on the OOUI board.Feb 21 2015, 8:26 PM
gerritbot subscribed.Mar 13 2015, 12:01 PM

Change 196571 had a related patch set uploaded (by Esanders):
Compensate for loss of margin when opening modals

https://gerrit.wikimedia.org/r/196571

gerritbot added a project: Patch-For-Review.Mar 13 2015, 12:01 PM
Esanders removed a project: Patch-For-Review.Mar 13 2015, 12:01 PM
Esanders edited subscribers, added: Eloquence; removed: gerritbot.
Aklapper mentioned this in T93229: Link dialog caused a scrolling frenzy.Mar 20 2015, 10:50 AM
matmarex closed this task as Resolved.Mar 21 2015, 5:11 PM
matmarex mentioned this in T93476: The OOUI hack to prevent scrolling while dialog is open causes page contents to move horizontally by scrollbar's width in RTL when dialog opens.

Still partially broken in RTL, filed T93476 to track this.

gerritbot added a comment.Mar 21 2015, 5:12 PM

Change 196571 merged by jenkins-bot:
Compensate for loss of margin when opening modals

https://gerrit.wikimedia.org/r/196571

Jdforrester-WMF closed this task as Resolved.Mar 21 2015, 8:45 PM
Jdforrester-WMF added a project: OOjs-UI-next-release.
Esanders mentioned this in rGOJU6a5914dda8f8: Compensate for loss of margin when opening modals.Mar 23 2015, 3:57 PM
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Mar 23 2015, 4:22 PM
Jdforrester-WMF moved this task from Doing to Reviewing on the OOUI board.Mar 26 2015, 8:56 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 29 2015, 11:27 PM
Jdforrester-WMF edited a custom field.Mar 29 2015, 11:34 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 29 2015, 11:50 PM
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.9.5); removed OOjs-UI-next-release.Apr 7 2015, 4:26 PM
Jdforrester-WMF added a project: WMF-deploy-2015-04-08_(1.26wmf1).Apr 8 2015, 8:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits