"Nested" dialogs (template inside a basic reference) break the OOUI hack to prevent scrolling while dialog is open
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

"Nested" dialogs (template inside a basic reference) break the OOUI hack to prevent scrolling while dialog is open (added in 4d87bde4495e5204b722d2154885f9c127ad30e3 / https://gerrit.wikimedia.org/r/#/c/179598/).

To reproduce:

View https://en.wikipedia.org/wiki/Skyfall#Casting, open VisualEditor
Open the first reference in this section (currently numbered [17], [15] in VE probably due to T52474)
- Observe that window scrollbar disappears.
- Observe that the window scrolls slightly (T89612).
The reference has two templates in it; open either one
Close the "nested" dialog
- Observe that the scrollbar has incorrectly reappeared, while it should only reappear after the "parent" dialog is closed.
- Observe that the position of the blue highlight on the [15] is not updated.

	Subject	Repo	Branch	Lines +/-
	Only modify body class when first/last window opens/closes	oojs/ui	master	+15 -2

Mentioned In: rGOJU46ca973385b7: Only modify body class when first/last window opens/closes
Mentioned Here: rGOJU4d87bde4495e: Prevent parent window scroll in modal mode using overflow hidden
T52474: In VisualEditor, references in templates cannot be reused and are numbered separately from references in the text.
T89612: The OOUI hack to prevent scrolling while dialog is open causes pages to scroll when dialog opens

matmarex assigned this task to • Esanders.

matmarex raised the priority of this task from to Needs Triage.

matmarex updated the task description. (Show Details)

matmarex subscribed.

Change 190806 had a related patch set uploaded (by Esanders):
Only modify body class when first/last window opens/closes

Jdforrester-WMF triaged this task as Medium priority.Feb 16 2015, 6:51 PM

Jdforrester-WMF set Security to None.

Change 190806 merged by jenkins-bot:
Only modify body class when first/last window opens/closes

Verified the fix in beta.