Cursor placement is acting totally randomly in VE in Betalabs right now with Firefox only
Steps to reproduce:
1.Open a page with VE
2.Select a text and apply link
Observe that, the context menu for link inspector opens far below the page.click on it and it jumps up the page .
Try to close the link inspector , it again jumps down the page.
Another case
Select a text , apply any styling like Bold, the cursor jumps to the beginning of the line.
See the video capture attached
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix unmodifiedness test in showSelection | VisualEditor/VisualEditor | master | +17 -5 |
Cursoring off a focusable node is also broken in Firefox: the page scrolls all the way down, and a subsequent arrow key press puts the cursor at the start of the document.
This and Rummana's report and the link inspector seem to be symptoms of the same bug: both when closing an inspector and when arrowing off a focusable node, the selection appears to go to something at the bottom of the page.
The Bold thing she mentioned seems different: after applying an annotation, the cursor simply jumps to the beginning of the line, which makes me suspect we just need to re-assert the selection or something.
It looks like this broke at ecdb3793f0870bc4f36de0e636f6ed79879e0d20 ("Only replace selection when we know it has changed").
Pressing ENTER in the middle of some text in Firefox is enough to get weird selection behaviour. Investigating further.
Change 192077 had a related patch set uploaded (by Divec):
Fix unmodifiedness test in showSelection
It's not pulled through yet. I submitted https://gerrit.wikimedia.org/r/#/c/192259/ to pull it though, but that's causing the tests to fail. Looking into that now.
I've fixed the failing tests for https://gerrit.wikimedia.org/r/#/c/192259/ by rebasing in part of one of Ed's changes, so once that gets merged the fix should be in beta labs.