Page MenuHomePhabricator
Create Task
Maniphest T90916

Test failure: "Uncaught TypeError: Cannot read property '0' of undefined" in mw.ImageInfoCache
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Currently causing mwext-VisualEditor-qunit-karma to fail.

I can consistently reproduce this locally using Chrome 40 with latest MediaWiki + VisualEditor (no other extensions) and running /wiki/Special:JavaScriptTest/qunit/plain in the browser.

TypeError: Cannot read property '0' of undefined
ve.init.mw.ImageInfoCache.processPage @ ve.init.mw.ImageInfoCache.js:40
processResult @ ve.init.mw.ApiResponseCache.js:153

Details

SubjectRepoBranchLines +/-
ImageInfoCache: Don't try to access imageinfo result if it's not setmediawiki/extensions/VisualEditormaster+9 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Feb 26 2015, 7:51 PM
Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added projects: VisualEditor, VisualEditor-MediaWiki.
Krinkle added subscribers: Jdforrester-WMF, Krinkle.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2015, 7:51 PM
Krinkle renamed this task from Test failure: "Uncaught TypeError: Cannot read property '0' of undefined" to Test failure: "Uncaught TypeError: Cannot read property '0' of undefined" in mw.ImageInfoCache.Feb 26 2015, 7:55 PM
Krinkle mentioned this in T89435: Test failure: Circular dependency between mw.Target and mw.ImageInfoCache.
Krinkle set Security to None.
Krenair claimed this task.Feb 26 2015, 9:53 PM
gerritbot subscribed.Feb 26 2015, 9:53 PM

Change 193268 had a related patch set uploaded (by Alex Monk):
ImageInfoCache: Don't try to access imageinfo result if it's not set

https://gerrit.wikimedia.org/r/193268

gerritbot added a project: Patch-For-Review.Feb 26 2015, 9:53 PM
Jdforrester-WMF triaged this task as Medium priority.Feb 28 2015, 12:56 AM
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
gerritbot added a comment.Feb 28 2015, 1:40 AM

Change 193268 merged by jenkins-bot:
ImageInfoCache: Don't try to access imageinfo result if it's not set

https://gerrit.wikimedia.org/r/193268

Krenair mentioned this in rEVED944e7d7a861f: ImageInfoCache: Don't try to access imageinfo result if it's not set.Feb 28 2015, 1:40 AM
Jdforrester-WMF closed this task as Resolved.Feb 28 2015, 2:31 AM
Jdforrester-WMF edited projects, added WMF-deploy-2015-03-04_(1.25wmf20); removed Patch-For-Review.
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Mar 3 2015, 11:28 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 9 2015, 6:04 PM
Jdforrester-WMF edited a custom field.Mar 9 2015, 6:10 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 9 2015, 6:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits