Test failure: Circular dependency between mw.Target and mw.ImageInfoCache
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Krinkle
	Feb 13 2015, 8:58 AM

Description

When running [[Special:JavaScriptTest/qunit/plain]] with VisualEditor installed, it currently fails during the ve.dm.TransactionProcessor test.

Sequence of events:

All ve/ve-mw files have been executed.
- ve.init.mw.Platform immediately created an instance of itself (ve.init.platform = ..)
- ve.init.mw.Platform instantiates ve.init.mw.ImageInfoCache (this.imageInfoCache = ..)
Test files are executing.
Test cases for ve.dm.TransactionProcessor.
ve.dm.MWImageNode is constructed.
ve.dm.MWImageNode#getScalablePromise is called.
getScalablePromise checks ve.init.platform.imageInfoCache. (It exists.)
getScalablePromise calls ve.init.platform.imageInfoCache.get.
imageInfoCache.get (inherited from mw.ApiResponseCache) calls ve.init.mw.ImageInfoCache#getRequestPromise.
getRequestPromise assumes ve.init.target exists, accessing apiRequest.
Boom!

This passes in production because the user doesn't initiate these code paths until after Platform and Target have settled.

Other files (e.g. ve.test.utils.js) instantiate their own Target object. The ve.dm.TransactionProcessor test (or something else) should also ensure that a target exists.

Details

	Subject	Repo	Branch	Lines +/-
	Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target	mediawiki/extensions/VisualEditor	master	+104 -148

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	hashar	T92946 Make mwext-Wikibase-qunit voting
Resolved	Tobi_WMDE_SW	T74184 fix the qunit tests for wikidata: mwext-Wikibase-qunit
Resolved	Krinkle	T74063 Jenkins: Convert mediawiki qunit from grunt-contrib-qunit (PhantomJS) to grunt-karma (Chromium)
Resolved	Krenair	T89435 Test failure: Circular dependency between mw.Target and mw.ImageInfoCache

Event Timeline

Krinkle created this task.Feb 13 2015, 8:58 AM

Krinkle raised the priority of this task from to Needs Triage.

Krinkle updated the task description. (Show Details)

Krinkle added projects: VisualEditor, VisualEditor-MediaWiki, Technical-Debt.

Krinkle added subscribers: Krinkle, Catrope.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2015, 8:58 AM

Jdforrester-WMF triaged this task as Medium priority.Feb 17 2015, 11:11 PM

Jdforrester-WMF set Security to None.

Jdforrester-WMF moved this task from To Triage to Planned Maintenance on the VisualEditor board.

Jdforrester-WMF added a subscriber: Mooeypoo.

While this error is only intermittently reported by Jenkins in the karma-qunit experimental job, this is likely because the build often fails earlier due to current issues with SQLite.

This is consistently failing locally using MediaWiki with VisualEditor installed. Both when running the tests manually in a web browser, and via grunt karma:main from MediaWiki core. As such it would block adoption of Karma as the tests are failing. I don't know why they're passing in PhantomJS. Possibly this test is being skipped or tolerated somehow.

For comparison, on the command line the ve.dm.TransactionProcessor failure surfaces as follows:

Uncaught TypeError: Cannot read property 'constructor' of undefined
ve.init.mw.ImageInfoCache.getRequestPromise
ve.init.mw.ApiResponseCache.processQueue
later

No rush however as there are other blockers on T74063 right now that will take some work to address first.

Krinkle added a parent task: T74063: Jenkins: Convert mediawiki qunit from grunt-contrib-qunit (PhantomJS) to grunt-karma (Chromium).Feb 18 2015, 12:33 AM

https://gerrit.wikimedia.org/r/#/c/186548/ would probably solve this.

Change 186548 had a related patch set uploaded (by Alex Monk):
Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target

https://gerrit.wikimedia.org/r/186548

gerritbot added a project: Patch-For-Review.Feb 25 2015, 1:51 AM

Krenair claimed this task.Feb 25 2015, 1:52 AM

Change 186548 merged by jenkins-bot:
Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target

https://gerrit.wikimedia.org/r/186548

Krenair mentioned this in rEVED8e48f9458005: Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target.Feb 25 2015, 5:26 PM

Now fixed?

Jdforrester-WMF closed this task as Resolved.Feb 25 2015, 7:05 PM

Might be fixed, don't I'm not sure why. The references causing the circular dependency where due to mw-ImageInfoCache using ve.init.platform, which depends on mw.Target, which ships mw.ImageInfoCache. From what I can see, that has not changed.

However, this error may be shadowed by T90916 which showed up in this bug's place. mediawiki-core-qunit-karma is passing at the moment.

Krinkle removed a project: Patch-For-Review.Feb 26 2015, 7:55 PM

Jdforrester-WMF moved this task from Planned Maintenance to FY 18-19 Q3/Q4 on the VisualEditor board.Mar 3 2015, 11:28 PM

Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 9 2015, 6:04 PM

Jdforrester-WMF edited a custom field.Mar 9 2015, 6:10 PM

Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 9 2015, 6:15 PM