Maniphest T91656

[Regression pre-wmf21] Comment icon is now huge
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Probably caused by @Esanders's change to OOjs UI to have the icons be "natural size".

Details

	Subject	Repo	Branch	Lines +/-
	ve.ce.CommentNode: Specify 'background-size' override	VisualEditor/VisualEditor	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned In: rGVEDf98bb5cd6cd7: ve.ce.CommentNode: Specify 'background-size' override

Event Timeline

Jdforrester-WMF created this task.Mar 5 2015, 5:00 PM

Jdforrester-WMF raised the priority of this task from to High.

Jdforrester-WMF updated the task description. (Show Details)

Jdforrester-WMF added a project: VisualEditor-EditingTools.

Jdforrester-WMF added subscribers: Jdforrester-WMF, • Esanders.

Restricted Application added a project: VisualEditor. · View Herald TranscriptMar 5 2015, 5:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Mar 5 2015, 6:31 PM

matmarex claimed this task.Mar 5 2015, 7:21 PM

matmarex merged a task: T91681: [Regression pre-wmf21] Comment icon is larger than the height of a line.

matmarex added a subscriber: Etonkovidova.

Etonkovidova merged a task: T91681: [Regression pre-wmf21] Comment icon is larger than the height of a line.Mar 5 2015, 7:44 PM

Change 194576 had a related patch set uploaded (by Bartosz Dziewoński):
ve.ce.CommentNode: Specify 'background-size' override

https://gerrit.wikimedia.org/r/194576

gerritbot added a project: Patch-For-Review.Mar 5 2015, 7:45 PM

Jdforrester-WMF moved this task from External and Administrivia to Blocked on the VisualEditor board.Mar 5 2015, 8:54 PM

Change 194576 merged by jenkins-bot:
ve.ce.CommentNode: Specify 'background-size' override

https://gerrit.wikimedia.org/r/194576

matmarex mentioned this in rGVEDf98bb5cd6cd7: ve.ce.CommentNode: Specify 'background-size' override.Mar 5 2015, 10:46 PM

Jdforrester-WMF closed this task as Resolved.Mar 5 2015, 10:51 PM

Jdforrester-WMF edited projects, added WMF-deploy-2015-03-11_(1.25wmf21); removed Patch-For-Review.

Jdforrester-WMF set Security to None.

Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Mar 6 2015, 4:31 PM

Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 9 2015, 5:50 PM

Jdforrester-WMF edited a custom field.Mar 9 2015, 5:59 PM

Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 9 2015, 6:16 PM

Verified the fix in beta.

Ryasmeen added a project: Verified-in-Phase0.Mar 12 2015, 12:59 AM

Etonkovidova added a project: Verified-in-Phase2.Mar 19 2015, 7:45 PM