Page MenuHomePhabricator
Create Task
Maniphest T91659

MobileFrontendHooks::onResourceLoaderTestModules is really slow
Closed, DeclinedPublic
Actions

Description

35.40% 365.997      1 - ResourceLoader::__construct
33.23% 343.579      1 - ResourceLoader::registerTestModules
32.90% 340.115      1 - hook: ResourceLoaderTestModules
32.88% 339.895      1 - MobileFrontendHooks::onResourceLoaderTestModules
32.87% 339.834      1 - MobileFrontendHooks::onResourceLoaderTestModules

Details

SubjectRepoBranchLines +/-
Simplify construction of qunit test modulemediawiki/extensions/MobileFrontendmaster+26 -28
Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.Mar 5 2015, 5:09 PM
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added projects: Web-Team-Backlog, Performance Issue.
Legoktm subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 5 2015, 5:09 PM
Krenair subscribed.Mar 5 2015, 8:40 PM
Krenair added a comment.Mar 5 2015, 8:48 PM

Run only if you set $wgEnableJavaScriptTest = true; - so in WMF production this is test2wiki only

• KLans_WMF moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Mar 6 2015, 6:10 PM
Florian subscribed.Mar 7 2015, 2:15 PM
Legoktm mentioned this in T78733: ResourceLoader slow under MediaWiki-Vagrant with VirtualBox.Mar 11 2015, 12:47 AM
gerritbot subscribed.Aug 14 2015, 7:54 PM

Change 231630 had a related patch set uploaded (by Jdlrobson):
Simplify construction of qunit test module

https://gerrit.wikimedia.org/r/231630

gerritbot added a project: Patch-For-Review.Aug 14 2015, 7:54 PM
Jdlrobson moved this task from Triaged but Future to 2017-18 Q3 on the Web-Team-Backlog board.Aug 14 2015, 10:50 PM
• Jhernandez triaged this task as Medium priority.Aug 17 2015, 12:40 PM
• Jhernandez edited projects, added MobileFrontend; removed Web-Team-Backlog.
• Jhernandez set Security to None.
• Jhernandez moved this task from Backlog to team:other on the MobileFrontend board.
gerritbot added a comment.Sep 14 2015, 12:52 AM

Change 231630 merged by jenkins-bot:
Simplify construction of qunit test module

https://gerrit.wikimedia.org/r/231630

• bmansurov mentioned this in rEMFR8547d4e0af8c: Simplify construction of qunit test module.Sep 14 2015, 12:53 AM
• Konfused-Kitten mentioned this in rMEXT7a863fa27d1d: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 14 2015, 12:53 AM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 14 2015, 1:00 AM
Jdlrobson closed this task as Resolved.Sep 16 2015, 7:36 PM
Jdlrobson claimed this task.
Legoktm reopened this task as Open.Sep 16 2015, 8:29 PM

We're now at:

10.19% 279.634      2 - MobileFrontendHooks::onResourceLoaderTestModules

For comparison:

1.32% 36.240      2 - EchoHooks::onResourceLoaderTestModules
0.39% 10.687      2 - ThanksHooks::onResourceLoaderTestModules
Jdlrobson added a comment.Sep 17 2015, 10:26 PM

Well it's a third of the speed now and you didn't specify a target measurement

Given MobileFrontend has a lot of tests I would expect it to be slower than Thanks and Echo.

What is the impact on tests? How much slower do they run like this? Will the world melt if we don't do anything?

Jdlrobson lowered the priority of this task from Medium to Lowest.Sep 17 2015, 10:27 PM

Until more clarity about the exact problem.

Jdlrobson removed a project: Patch-For-Review.Sep 23 2015, 7:24 PM
Jdlrobson removed Jdlrobson as the assignee of this task.Nov 4 2015, 4:39 PM
Jdlrobson moved this task from team:other to Discussing on the MobileFrontend board.
Jdlrobson subscribed.
MBinder_WMF added a project: Web-Team-Backlog.Apr 27 2016, 4:28 PM
MBinder_WMF moved this task from 2017-18 Q3 to Incoming on the Web-Team-Backlog board.Apr 27 2016, 4:34 PM
MBinder_WMF moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jul 4 2016, 7:23 PM
Jdlrobson closed this task as Declined.Jun 5 2017, 6:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits