Maniphest T91900

Plain message key on deleted topic pages
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Florian
	Mar 7 2015, 7:22 PM

Tags

Referenced Files

	F58482: Unbenannt.JPG
	Mar 7 2015, 7:22 PM

	F58486: Unbenannt.JPG
	Mar 7 2015, 7:22 PM

Subscribers

• Mattflaschen-WMF

Description

If i visit a deleted flow topic (at least with a non-privileged account), e.g. https://www.mediawiki.org/wiki/Topic:Sd3qkquvywwoib5y, i see the following:

The message key doesn't exist.

For info the qqx:

Unbenannt.JPG (283×753 px, 51 KB)

We should check what we're supposed to be showing here (probably the deletion log?) then show a valid error message.

Related to this, @demon spotted the following PHP warnings in prod (message taken from Task T90910: Undefined variables (type, start) in Block/Topic.php:
Spotted in production with 1.25wmf19:

2 Undefined variable: type in /srv/mediawiki/php-1.25wmf19/extensions/Flow/includes/Block/Topic.php on line 816
2 Undefined variable: start in /srv/mediawiki/php-1.25wmf19/extensions/Flow/includes/Block/Topic.php on line 816

Related Objects

Mentioned Here: T90910: Undefined variables (type, start) in Block/Topic.php

Event Timeline

Florian created this task.Mar 7 2015, 7:22 PM

Florian raised the priority of this task from to Needs Triage.

Florian updated the task description. (Show Details)

Florian subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2015, 7:22 PM

Florian set Security to None.Mar 7 2015, 7:22 PM

Florian added a project: StructuredDiscussions.Mar 7 2015, 7:25 PM

Liuxinyu970226 subscribed.Mar 8 2015, 12:26 PM

Florian merged a task: T91946: flow-error-not-allowed-view-to when viewing deleted topic.Mar 8 2015, 10:30 PM

Florian added a subscriber: • Mattflaschen-WMF.

• Mattflaschen-WMF triaged this task as High priority.Mar 8 2015, 11:35 PM

• Mattflaschen-WMF updated the task description. (Show Details)

matthiasmullie closed this task as a duplicate of T90900: Remove obvious mistakenly added refs in mediawiki/core repo.Mar 9 2015, 8:43 AM

matthiasmullie merged a task: T90910: Undefined variables (type, start) in Block/Topic.php.Mar 9 2015, 8:46 AM

matthiasmullie added subscribers: EBernhardson, • demon.

Liuxinyu970226 unsubscribed.Mar 9 2015, 8:46 AM

matthiasmullie reopened this task as Open.Mar 9 2015, 8:46 AM

matthiasmullie added a subscriber: Liuxinyu970226.

Florian updated the task description. (Show Details)Mar 9 2015, 8:50 AM

Florian added a project: Wikimedia-production-error.

Krenair subscribed.Mar 9 2015, 4:43 PM

Doesn't show up anymore on mediawiki.org and the notices have been fixed: T90910: Undefined variables (type, start) in Block/Topic.php

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 1 2015, 2:27 PM

• DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Jun 1 2015, 4:26 PM

Liuxinyu970226 unsubscribed.Jun 1 2015, 10:40 PM

• demon moved this task from Untriaged to Resolved on the Wikimedia-production-error board.Jun 12 2015, 6:35 PM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:12 PM