Page MenuHomePhabricator
Create Task
Maniphest T92496

style of <inputbox> inputfield is copied to editbox and summary in preview mode
Closed, ResolvedPublic
Actions

Description

If there is an <inputbox> tag on a page and you edit this page, the style of the <inputbox> inputfield is copied to the editbox and the summary field in preview mode. The monospace font of the editbox is lost and a blue line appears at the left side of the editbox and the summary field. Happens on english and german wiktionary since 1.25wmf20.

  1. goto en.wiktionary.org
  2. select a random page
  3. Press edit-tab
  4. notice: monospace font in editbox!
  5. enter the folling three lines somewhere on the page:

<inputbox>
type=create
</inputbox>

  1. Press "show preview" Button
  2. notice: monospace font in editbox is lost and a blue line at the left side of the editbox and the summary field appears during input

pasted_file (798×1 px, 52 KB)

Details

SubjectRepoBranchLines +/-
Html: Make addition of 'mw-ui-input' conditional on $wgUseMediaWikiUIEverywheremediawiki/corewmf/1.25wmf20+17 -16
Html: Make addition of 'mw-ui-input' conditional on $wgUseMediaWikiUIEverywheremediawiki/corewmf/1.25wmf21+17 -16
Html: Make addition of 'mw-ui-input' conditional on $wgUseMediaWikiUIEverywheremediawiki/coremaster+17 -16
Customize query in gerrit

Related Objects

Event Timeline

Formatierer created this task.Mar 12 2015, 2:04 PM
Formatierer raised the priority of this task from to Needs Triage.
Formatierer updated the task description. (Show Details)
Formatierer subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2015, 2:04 PM
Krenair added a project: MediaWiki-extensions-InputBox.Mar 12 2015, 2:05 PM
Krenair set Security to None.
FriedhelmW triaged this task as Unbreak Now! priority.Mar 12 2015, 7:44 PM
FriedhelmW subscribed.
Aklapper added a comment.Mar 13 2015, 8:59 AM

@FriedhelmW: Please see https://www.mediawiki.org/wiki/Phabricator/Project_management#Setting_task_priorities

Aklapper lowered the priority of this task from Unbreak Now! to Medium.Mar 13 2015, 8:59 AM
Aklapper added a project: Regression.
Raymond subscribed.Mar 13 2015, 3:50 PM
Thgoiter subscribed.Mar 13 2015, 6:11 PM
matmarex raised the priority of this task from Medium to High.Mar 13 2015, 6:39 PM
matmarex updated the task description. (Show Details)
matmarex added projects: MediaWiki-User-Interface, UI-Standardization.
matmarex added a subscriber: Jdlrobson.
matmarex subscribed.

This is triggered by the InputBox extension, but the problem lies somewhere else.

Since 99277a4d0fea425a90af6b6be713e5015d7b3c48, InputBox uses "MediaWiki UI" styles for its own form fields (example: F89124). This requires loading additional style modules that are not present on all pages, in particular mediawiki.ui.input, which applies the styling seen in the screenshot linked above to all text fields with the .mw-ui-input CSS class.

It turns out that, for some reason, the main edit box (<textarea id="wpTextbox1" …>) also has this class, even without InputBox being present – it's just that the styles were previously not being loaded. It probably shouldn't have it unless $wgUseMediaWikiUIEverywhere configuration variable is enabled (and it is false by default, and on Wikimedia wikis). I think Jon was the primary person caring about that configuration variable :)

If I remember correctly, the Design team does intend for this to become the styling for all text boxes, but this has been questioned e.g. on T72028. We definitely shouldn't do this now by accident (and possibly not at all, but that's a different discussion); T72028 is probably a good place to have it.

matmarex added a comment.Mar 13 2015, 6:40 PM

(Hmm, and an issue similar to this was also raised on T72028.)

matmarex mentioned this in T72028: Should Mediawiki UI change font-family for textareas?.Mar 13 2015, 6:45 PM
gerritbot subscribed.Mar 13 2015, 6:51 PM

Change 196623 had a related patch set uploaded (by Bartosz Dziewoński):
Html: Make addition of 'mw-ui-input' conditional on $wgUseMediaWikiUIEverywhere

https://gerrit.wikimedia.org/r/196623

gerritbot added a project: Patch-For-Review.Mar 13 2015, 6:51 PM
gerritbot added a comment.Mar 13 2015, 8:09 PM

Change 196623 merged by jenkins-bot:
Html: Make addition of 'mw-ui-input' conditional on $wgUseMediaWikiUIEverywhere

https://gerrit.wikimedia.org/r/196623

He7d3r subscribed.Mar 14 2015, 3:17 AM
Florian closed this task as Resolved.Mar 15 2015, 12:35 AM
Florian claimed this task.
Florian subscribed.

The problem is resolved with the change of @matmarex :)

Ricordisamoa reassigned this task from Florian to matmarex.Mar 15 2015, 11:16 AM
Ricordisamoa removed a project: Patch-For-Review.
Ricordisamoa subscribed.
matmarex added a comment.Mar 15 2015, 6:26 PM

Yeah. The change will be deployed to Wiktionaries on Tuesday, 24 March 2015, per https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap. It could be scheduled for an earlier SWAT deployment (https://wikitech.wikimedia.org/wiki/Deployments), but I personally won't be able to babysit it.

WeernFootis1 subscribed.Mar 15 2015, 7:51 PM

Another 10 days for Wikipedia? Come on, please be faster...

gerritbot added a comment.Mar 15 2015, 8:29 PM

Change 196896 had a related patch set uploaded (by Florianschmidtwelzow):
Html: Make addition of 'mw-ui-input' conditional on $wgUseMediaWikiUIEverywhere

https://gerrit.wikimedia.org/r/196896

gerritbot added a project: Patch-For-Review.Mar 15 2015, 8:29 PM

Change 196897 had a related patch set uploaded (by Florianschmidtwelzow):
Html: Make addition of 'mw-ui-input' conditional on $wgUseMediaWikiUIEverywhere

https://gerrit.wikimedia.org/r/196897

Florian added a comment.Mar 15 2015, 8:31 PM

Thanks @matmarex for the info :) I have cherry picked it and will plan a SWAT for it.

Thgoiter awarded a token.Mar 15 2015, 9:00 PM
Florian added a comment.Mar 15 2015, 9:47 PM
In T92496#1120129, @Florian wrote:

will plan a SWAT for it.

See https://wikitech.wikimedia.org/w/index.php?title=Deployments&action=historysubmit&diff=148254&oldid=148251

gerritbot added a comment.Mar 16 2015, 3:21 PM

Change 196896 merged by jenkins-bot:
Html: Make addition of 'mw-ui-input' conditional on $wgUseMediaWikiUIEverywhere

https://gerrit.wikimedia.org/r/196896

gerritbot added a comment.Mar 16 2015, 3:21 PM

Change 196897 merged by jenkins-bot:
Html: Make addition of 'mw-ui-input' conditional on $wgUseMediaWikiUIEverywhere

https://gerrit.wikimedia.org/r/196897

Florian added a subscriber: Anomie.Mar 16 2015, 3:36 PM

@WeernFootis1 and @all: The change is now (like @gerritbot wrote) merged and it was deployed just a moment ago by @Anomie (thanks!). All wmf-wikis now works as expected :)

Jdlrobson added a comment.Mar 17 2015, 11:40 PM

Thanks @Anomie and @Florian ! :)

matmarex mentioned this in rMW896fdb3d9740: Html: Make addition of 'mw-ui-input' conditional on $wgUseMediaWikiUIEverywhere.Mar 23 2015, 3:51 PM
Anomie mentioned this in rMW16f92426cebc: Html: Make addition of 'mw-ui-input' conditional on $wgUseMediaWikiUIEverywhere.Mar 23 2015, 3:51 PM
Florian mentioned this in rMW2ec346a5c898: Html: Make addition of 'mw-ui-input' conditional on $wgUseMediaWikiUIEverywhere.Mar 23 2015, 3:51 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits