Page MenuHomePhabricator
Create Task
Maniphest T92868

MWAlienNodes should have a minimum height and width and an icon
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Nodes that VE does not recognize are initialized into ve.ce.MWAlienNode and are focusable. However, similarly to what we had with empty/hidden transclusions, some of the alien nodes are empty, which makes them dimensionless and impossible for the user to interact with (even only to delete/move)

Alien nodes should have a minimum width/height in case they are empty.

We've done this before to MWTransclusionNode, see this patchset:

Details

SubjectRepoBranchLines +/-
Adding minimum width and height to MWAlienExtensionNodesmediawiki/extensions/VisualEditormaster+56 -3
Assigning width and height to alien extension nodesmediawiki/extensions/VisualEditormaster+57 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Mooeypoo created this task.Mar 16 2015, 6:08 PM
Mooeypoo raised the priority of this task from to Needs Triage.
Mooeypoo updated the task description. (Show Details)
Mooeypoo added a project: VisualEditor.
Mooeypoo subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2015, 6:08 PM
Mooeypoo added a parent task: T89287: Graph editing in VisualEditor.Mar 16 2015, 6:09 PM
Niharika mentioned this in T89287: Graph editing in VisualEditor.Mar 16 2015, 6:12 PM
Ankita-ks subscribed.Mar 16 2015, 6:17 PM
Rits subscribed.Mar 16 2015, 6:32 PM
siddhism_ subscribed.Mar 16 2015, 8:06 PM
gerritbot subscribed.Mar 20 2015, 9:46 PM

Change 198397 had a related patch set uploaded (by Rits):
Assigning width and height to MWAlienNodes

https://gerrit.wikimedia.org/r/198397

gerritbot added a project: Patch-For-Review.Mar 20 2015, 9:46 PM
Jdforrester-WMF assigned this task to Rits.Mar 20 2015, 11:30 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
Jdforrester-WMF set Security to None.
• ferdbold subscribed.Mar 23 2015, 1:46 PM
gerritbot added a comment.Apr 1 2015, 10:50 PM

Change 200945 had a related patch set uploaded (by Rits):
Assigning width and height to alien extension nodes

https://gerrit.wikimedia.org/r/200945

gerritbot added a comment.Apr 2 2015, 5:34 PM

Change 200945 abandoned by Jforrester:
Assigning width and height to alien extension nodes

Reason:
Dupe of I9387f17e.

https://gerrit.wikimedia.org/r/200945

Jdforrester-WMF closed this task as Resolved.Apr 8 2015, 4:57 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-04-08_(1.26wmf1), VisualEditor 2014/15 Q4 blockers; removed Patch-For-Review.
Jdforrester-WMF edited a custom field.
gerritbot added a comment.Apr 8 2015, 5:17 PM

Change 198397 merged by jenkins-bot:
Adding minimum width and height to MWAlienExtensionNodes

https://gerrit.wikimedia.org/r/198397

Jdforrester-WMF mentioned this in rEVEDd67543745fa9: Adding minimum width and height to MWAlienExtensionNodes.Apr 8 2015, 5:17 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.Apr 8 2015, 7:00 PM
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Apr 16 2015, 9:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits