Page MenuHomePhabricator

MWAlienNodes should have a minimum height and width and an icon
Closed, ResolvedPublic1 Story Points

Description

Nodes that VE does not recognize are initialized into ve.ce.MWAlienNode and are focusable. However, similarly to what we had with empty/hidden transclusions, some of the alien nodes are empty, which makes them dimensionless and impossible for the user to interact with (even only to delete/move)

Alien nodes should have a minimum width/height in case they are empty.

We've done this before to MWTransclusionNode, see this patchset:

Event Timeline

Mooeypoo created this task.Mar 16 2015, 6:08 PM
Mooeypoo raised the priority of this task from to Needs Triage.
Mooeypoo updated the task description. (Show Details)
Mooeypoo added a project: VisualEditor.
Mooeypoo added a subscriber: Mooeypoo.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2015, 6:08 PM
Rits added a subscriber: Rits.Mar 16 2015, 6:32 PM

Change 198397 had a related patch set uploaded (by Rits):
Assigning width and height to MWAlienNodes

https://gerrit.wikimedia.org/r/198397

Jdforrester-WMF triaged this task as Normal priority.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
Jdforrester-WMF set Security to None.

Change 200945 had a related patch set uploaded (by Rits):
Assigning width and height to alien extension nodes

https://gerrit.wikimedia.org/r/200945

Change 200945 abandoned by Jforrester:
Assigning width and height to alien extension nodes

Reason:
Dupe of I9387f17e.

https://gerrit.wikimedia.org/r/200945

Change 198397 merged by jenkins-bot:
Adding minimum width and height to MWAlienExtensionNodes

https://gerrit.wikimedia.org/r/198397

Jdforrester-WMF moved this task from Blocked to Q4 on the VisualEditor board.Apr 16 2015, 9:12 PM