Page MenuHomePhabricator
Create Task
Maniphest T92911

Strange indent for <pre> sections in LQT converted topics, only in Board view
Closed, ResolvedPublic
Actions

Description

When I view topics that have <pre> or spaced-indent text, in the Board-page, there are some formatting oddities - a very large (hundreds of pixels) indent.

E.g. at http://flow-tests.wmflabs.org/wiki/Testwiki:Support_desk
go to the topic "A lot of system pages don't have "nofollow, noindex" tags" and look at the 2 posts by User:88.130.125.116 and User:Fokebox

Screenshot_from_2015-03-16_15:35:12.png (1×1 px, 125 KB)

Ditto for the post by User:85.233.12.114, in the topic open_basedir to folder i did not found...

However, it looks fine/expected when seen in the Topic-pages themselves:

Details

SubjectRepoBranchLines +/-
Don't re-apply parent indent in partialsmediawiki/extensions/Flowmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Quiddity created this task.Mar 16 2015, 10:58 PM
Quiddity raised the priority of this task from to Needs Triage.
Quiddity updated the task description. (Show Details)
Quiddity added projects: StructuredDiscussions, Collaboration-Team-Triage.
Quiddity subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2015, 10:58 PM
EBernhardson triaged this task as Unbreak Now! priority.Mar 17 2015, 5:48 PM
EBernhardson subscribed.

We want to convert mw.org next week, this needs to be looked into before then.

• DannyH edited projects, added Collaboration-Team-Sprint-S-2015-03-25; removed Collaboration-Team-Triage.Mar 17 2015, 5:49 PM
• DannyH set Security to None.
• Mattflaschen-WMF added a parent task: T92303: Convert LQT pages on MediaWiki.org to Flow (tracking).Mar 20 2015, 6:15 PM
gerritbot subscribed.Mar 23 2015, 11:58 AM

Change 198708 had a related patch set uploaded (by Matthias Mullie):
Don't re-apply parent indent in partials

https://gerrit.wikimedia.org/r/198708

gerritbot added a project: Patch-For-Review.Mar 23 2015, 11:58 AM
matthiasmullie subscribed.Mar 23 2015, 12:00 PM

It's no major problem. It only happens when the post is displayed with JS, due to a problem with how Handlebars re-applies indents in partials.

A simple patch can fix it, but even if that doesn't get in in time, this shouldn't block mw.org deployment.

matthiasmullie claimed this task.Mar 23 2015, 12:01 PM
matthiasmullie moved this task from Sprint S - ends March 25 to Needs Code Review on the Collaboration-Team-Sprint-S-2015-03-25 board.
EBernhardson moved this task from Needs Code Review to Product Review on the Collaboration-Team-Sprint-S-2015-03-25 board.Mar 23 2015, 5:16 PM
gerritbot added a comment.Mar 23 2015, 5:25 PM

Change 198708 merged by jenkins-bot:
Don't re-apply parent indent in partials

https://gerrit.wikimedia.org/r/198708

EBernhardson closed this task as Resolved.Mar 23 2015, 5:37 PM
Diffusion mentioned this in rMEXT1788badba817: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 24 2015, 5:37 PM
matthiasmullie mentioned this in rEFLW5e4c1df5aa2b: Don't re-apply parent indent in partials.Mar 24 2015, 5:38 PM
• Mattflaschen-WMF moved this task from Product Review to Done on the Collaboration-Team-Sprint-S-2015-03-25 board.Mar 25 2015, 6:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL