Page MenuHomePhabricator

Hovercards aren't always triggered when a specific Chinese variant is used on the Chinese Wikipedia
Closed, ResolvedPublic


When viewing the Chinese Wikipedia while specifying a specific variant (zh-tw, zh-cn, etc.), Hovercards aren't always triggered when you mouse over links. Compare: (no variant conversion enabled) (Traditional Chinese (Taiwan) chosen)

In the second example, most of the links in the first paragraph do not trigger Hovercards. This significantly impairs the usefulness of the feature, as most readers would generally be reading in one variant or another.

Event Timeline

wctaiwan created this task.Mar 23 2015, 5:39 PM
wctaiwan raised the priority of this task from to Needs Triage.
wctaiwan updated the task description. (Show Details)
wctaiwan added a subscriber: wctaiwan.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2015, 5:39 PM
wctaiwan added a comment.EditedMar 23 2015, 6:02 PM

I'm not sure if the following is correct, but based on fiddling in my sandbox, it seems that Hovercards are triggered if:

  • Variant conversion is not enabled (seemingly not affected by whether the link text's variant matches that of the target page title), or if
  • The variant selected for viewing matches that of the target page title
  • The trivial case where there happens to be no difference between variants

Testing is made more difficult by the fact that there generally exists a redirect from one variant to the canonical title, and Hovercards do follow redirects.

See for examples:

  • The first line contains two links, the first to the article on Irish people (which has a Simplified Chinese title), the second to the Traditional Chinese redirect to the same article.
  • The second line contains two links to the same page, just in different variants. The title of the page and the first link are in Traditional Chinese.

  • All links trigger Hovercards

  • On the first line, only the second link triggers Hovercards
  • On the second line, both links trigger Hovercards (target title variant matches displayed variant)

  • On the first line, only the first link triggers Hovercards
  • On the second line, neither link triggers Hovercards

It seems like part of the issue is with linkHref and expectedHref not being the same in this function. Changing the function in JavaScript console to remove the .filter() portion and rerunning the triggers makes a few more links trigger Hovercards, though still not all of them.

wctaiwan claimed this task.Mar 25 2015, 8:52 PM

I think I've got a reasonable fix. Will upload a patch in a second.

Change 199694 had a related patch set uploaded (by Wctaiwan):
Use href attribute to calculate titles

Change 199694 merged by jenkins-bot:
Use href attribute to calculate titles

Is this resolved now?

The patch has been merged. I'm waiting for it to be deployed so I can verify that it's working.

wctaiwan set Security to None.
Quiddity moved this task from Backlog to Done on the Page-Previews board.Jun 21 2015, 10:49 PM