Page MenuHomePhabricator

language screenshot job for Persian (fa) seems to run correctly, but marked as failure
Closed, ResolvedPublic

Description

This job appears to have run correctly:
https://integration.wikimedia.org/ci/view/BrowserTests/view/VisualEditor/job/browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox/LANGUAGE_SCREENSHOT_CODE=fa,label=contintLabsSlave%20&&%20UbuntuTrusty/25/console

  • all the scenarios are green
  • all the files that are supposed to be uploaded to Commons in the end are indeed uploaded

However, it is marked as failure. It repeatedly happens for language "fa".

Event Timeline

Amire80 raised the priority of this task from to Needs Triage.
Amire80 updated the task description. (Show Details)
Amire80 added subscribers: Amire80, zeljkofilipin.
Amire80 set Security to None.

Looking at one of the job:

00:36:23.487 Performance: File TEST-features-language_screenshot.xml reported 0.0% of errors [SUCCESS]. Build status is: FAILURE

Might be a weird issue with the Jenkins Performance Plugin we have enabled on browser tests. There is not much information in the log though.

Looks like this is the problem:

https://integration.wikimedia.org/ci/view/BrowserTests/view/VisualEditor/job/browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox/LANGUAGE_SCREENSHOT_CODE=fa,label=contintLabsSlave%20&&%20UbuntuTrusty/30/consoleFull

...
09:29:12.055 /mnt/jenkins-workspace/workspace/browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox/LANGUAGE_SCREENSHOT_CODE/fa/label/gems/2.0.0/gems/mediawiki_api-0.3.1/lib/mediawiki_api/client.rb:167:in `send_request': A file with name "VisualEditor_Insert_Menu-fa.png" already exists in the shared file repository, and cannot be overwritten. (fileexists-shared-forbidden) (MediawikiApi::ApiError)
...

$ bundle exec upload
Uploading ./screenshots/VisualEditor_Formula_Insert_Menu-fa.png
/Library/Ruby/Gems/2.0.0/gems/mediawiki_api-0.3.1/lib/mediawiki_api/client.rb:167:in `send_request': A file with name "VisualEditor_Insert_Menu-fa.png" already exists in the shared file repository, and cannot be overwritten. (fileexists-shared-forbidden) (MediawikiApi::ApiError)
	from /Library/Ruby/Gems/2.0.0/gems/mediawiki_api-0.3.1/lib/mediawiki_api/client.rb:188:in `raw_action'
	from /Library/Ruby/Gems/2.0.0/gems/mediawiki_api-0.3.1/lib/mediawiki_api/client.rb:30:in `action'
	from /Library/Ruby/Gems/2.0.0/gems/mediawiki_api-0.3.1/lib/mediawiki_api/client.rb:122:in `upload_image'
	from /Library/Ruby/Gems/2.0.0/gems/commons_upload-0.0.2/lib/commons_upload.rb:29:in `image'
	from /Library/Ruby/Gems/2.0.0/gems/commons_upload-0.0.2/lib/commons_upload.rb:40:in `block in images'
	from /Library/Ruby/Gems/2.0.0/gems/commons_upload-0.0.2/lib/commons_upload.rb:38:in `each'
	from /Library/Ruby/Gems/2.0.0/gems/commons_upload-0.0.2/lib/commons_upload.rb:38:in `images'
	from /Library/Ruby/Gems/2.0.0/gems/commons_upload-0.0.2/bin/upload:4:in `<top (required)>'
	from /usr/bin/upload:23:in `load'
	from /usr/bin/upload:23:in `<main>'

@Amire80: I have assigned the task to you, since we have found the problem. Could you please assign it to someone that can fix the problem, or create a subtask? Thanks.

Amire80 added a subscriber: Elitre.

One of the files was a redirect to another file. This confused the uploading API, so it raised an exception that rendered the whole job red. And this is actually correct, but was kinda hard to find :)

@Elitre deleted the redirect, and now it works well.