Improve Graphoid code
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• mobrovac
	Mar 25 2015, 1:58 PM

Description

Before deploying Graphoid, it's code needs to be cleaned up a bit. Namely:

Update to the latest version of [Deprecated] service-template-node - T94013
Remove unnecessary code inherited from the template (in routes/) - T93919
Write Graphoid-specific tests - T93921
Make the tests pass (currently not even JSHint checks pass) - T93911

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Minor logger fixes	mediawiki/services/graphoid	master	+13 -5

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Yurik	T87406 Deploy Graph Extension to all Wikipedias
Resolved	Yurik	T73227 Graph extension does not have a fallback for non-JavaScript browsers
Resolved	akosiaris	T90487 Deploy graphoid service into production
Resolved	Yurik	T93881 Improve Graphoid code
Resolved	Yurik	T93911 Make graphoid pass jshint tests
Resolved	Yurik	T93919 Remove unnecessary Graphoid code inherited from the template (in routes/)
Resolved	Yurik	T93921 Write Graphoid-specific tests
Resolved	Yurik	T94013 Update Graphoid to the latest version of service-template-node
Resolved	Yurik	T95417 Graphoid Code Review

Event Timeline

• mobrovac created this task.Mar 25 2015, 1:58 PM

• mobrovac assigned this task to Yurik.

• mobrovac raised the priority of this task from to High.

• mobrovac updated the task description. (Show Details)

• mobrovac added projects: MediaWiki-extensions-Graph, Services.

• mobrovac subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2015, 1:58 PM

• mobrovac added a parent task: T90487: Deploy graphoid service into production.Mar 25 2015, 1:59 PM

• mobrovac updated the task description. (Show Details)Mar 26 2015, 9:44 AM

• mobrovac set Security to None.

• mobrovac added a subtask: T94013: Update Graphoid to the latest version of service-template-node.

• mobrovac added a project: Scrum-of-Scrums.Apr 1 2015, 5:17 PM

Yurik closed subtask T94013: Update Graphoid to the latest version of service-template-node as Resolved.Apr 6 2015, 6:19 AM

Yurik updated the task description. (Show Details)Apr 6 2015, 6:29 AM

Yurik updated the task description. (Show Details)Apr 6 2015, 6:50 AM

Yurik closed subtask T93911: Make graphoid pass jshint tests as Resolved.Apr 6 2015, 9:00 PM

Yurik closed subtask T93919: Remove unnecessary Graphoid code inherited from the template (in routes/) as Resolved.Apr 6 2015, 9:02 PM

Yurik closed subtask T93921: Write Graphoid-specific tests as Resolved.Apr 6 2015, 10:26 PM

Please file additional issues as separate tasks.

Reopening due to unmet dependencies

Yurik closed subtask T93921: Write Graphoid-specific tests as Resolved.Apr 8 2015, 9:42 AM

• mobrovac added a subtask: T95417: Graphoid Code Review.Apr 8 2015, 12:01 PM

• mobrovac closed subtask T95417: Graphoid Code Review as Resolved.Apr 8 2015, 9:02 PM

Should this issue be closed now?

Gave it a final look, looks good now, so resolving.

The only thing left to deal with are vega logs which get printed to stderr, and looking at the code, that's a hardcoded feature unfortunately. Having these logs in production could help a lot.

Vega is on github, send them an issue)

Change 203009 had a related patch set uploaded (by Mobrovac):
Minor logger fixes

https://gerrit.wikimedia.org/r/203009

gerritbot added a project: Patch-For-Review.Apr 9 2015, 9:13 AM

Change 203009 merged by Yurik:
Minor logger fixes

https://gerrit.wikimedia.org/r/203009

• mobrovac mentioned this in rGGRA314426646fe7: Minor logger fixes.Apr 9 2015, 5:20 PM

• mobrovac removed projects: Patch-For-Review, Scrum-of-Scrums.Apr 9 2015, 5:55 PM

Yurik moved this task from Backlog to Graphoid on the MediaWiki-extensions-Graph board.Apr 16 2015, 4:03 PM

Ricordisamoa added a project: Graphoid.Apr 16 2015, 9:12 PM

Ricordisamoa subscribed.

Yurik removed a project: MediaWiki-extensions-Graph.Apr 16 2015, 9:18 PM