Page MenuHomePhabricator

Improve Graphoid code
Closed, ResolvedPublic

Description

Before deploying Graphoid, it's code needs to be cleaned up a bit. Namely:

  • Update to the latest version of service-template-node - T94013
  • Remove unnecessary code inherited from the template (in routes/) - T93919
  • Write Graphoid-specific tests - T93921
  • Make the tests pass (currently not even JSHint checks pass) - T93911

Event Timeline

mobrovac assigned this task to Yurik.
mobrovac raised the priority of this task from to High.
mobrovac updated the task description. (Show Details)
mobrovac added a subscriber: mobrovac.

Please file additional issues as separate tasks.

Reopening due to unmet dependencies

Should this issue be closed now?

Gave it a final look, looks good now, so resolving.

The only thing left to deal with are vega logs which get printed to stderr, and looking at the code, that's a hardcoded feature unfortunately. Having these logs in production could help a lot.

Vega is on github, send them an issue)

Change 203009 had a related patch set uploaded (by Mobrovac):
Minor logger fixes

https://gerrit.wikimedia.org/r/203009