misspelling has configuration for languages da, de, en, hu and nl, consisting of a category and/or template per language. However these configuration values are only per-language, and no error is show if the specified category or template does not exist on the target wiki.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| [bugfix] Enable misspelling.py for several sites using wikidata | pywikibot/core | master | +94 -75 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T94679 scripts that do not check site correctly | |||
| Resolved | Xqt | T94681 misspelling only uses per-language configuration, and doesnt report a problem on sites missing specified templates | |||
| Open | None | T104821 Load settings from site | |||
| Resolved | Xqt | T258859 misspelling.py: Add support for site wikipedia:ne |
Event Timeline
Comment Actions
Note that misspelling does report an error on wikidata, as the script uses 'code' instead of lang, and the code for wikidata is 'wikidata', which doesnt appear in the configuration dictionary.
Comment Actions
By the way I think it's the other way around: With T94679 fixed this would be a relatively easy task.
This comment was removed by XZise.
Comment Actions
The table is a localisation table defined for site not for language. It is the right behaviour to report an error when a site is not configured.
Comment Actions
Yes, using code instead of lang is appropriate.
However, when the script is run on wiktionary, the values are not valid.
i.e. this script assumes it is run on Wikipedia only.
Comment Actions
Change 266073 had a related patch set uploaded (by Xqt):
[L10N] use sitename to find the the corresponding site.
Comment Actions
Change 266073 had a related patch set uploaded (by Xqt):
[bugfix] Fix comparing template name
Comment Actions
@Xqt: Hi! This task has been assigned to you a while ago. Could you maybe share an update? Do you still plan to work on this task?
If this task is not resolved and only if you do not plan to work on this task anymore: Please consider removing yourself as assignee (via Add Action... → Assign / Claim in the dropdown menu): That would allow others to work on this (in theory), as others won't think that someone is already working on this. Thanks! :)
Comment Actions
This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!
For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)
Comment Actions
Change 266073 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Enable misspelling.py for several sites using wikidata