<flow-error-not-allowed-view-to-delete-topic> is in use but is missing.
https://www.mediawiki.org/wiki/Topic:Sdko6823xasjoj7x (logged out)
https://ru.wikipedia.org/wiki/%D0%A2%D0%B5%D0%BC%D0%B0:Sepbvqy8zb1kvctb (logged in)
Glaisher | |
Apr 2 2015, 2:58 PM |
F108159: Снимокdel.PNG | |
Apr 2 2015, 5:52 PM |
<flow-error-not-allowed-view-to-delete-topic> is in use but is missing.
https://www.mediawiki.org/wiki/Topic:Sdko6823xasjoj7x (logged out)
https://ru.wikipedia.org/wiki/%D0%A2%D0%B5%D0%BC%D0%B0:Sepbvqy8zb1kvctb (logged in)
( https://phabricator.wikimedia.org/T90319#1174366 )
+ <flow-error-not-allowed-view-to-delete->
I mean the URL for @Sunpriat's screenshot, since there it doesn't even say flow-error-not-allowed-view-to-delete-topic, just flow-error-not-allowed-view-to-delete-
@Mattflaschen: it's the same message. The screenshot just happened before https://gerrit.wikimedia.org/r/#/c/200852/, which caused the "topic" suffix to be missing.
Please post the URL of that.
https://ru.wikipedia.org/wiki/%D0%A2%D0%B5%D0%BC%D0%B0:Sepbvqy8zb1kvctb
The logic in Topic::getDisallowedErrorMessage makes it hard to see all the message keys that are actually required. the generic fallback at the end is a good idea but it is not implemented correctly in the context of LogEventsList::showLogExtract.
@SBisson, what else needs to be done here? If the fallback is suitable, can we mark it Resolved?
@Mattflaschen, we could
a) come up with all the keys that the algorithm can possibly generate and add them to qqq so they can be translated
b) get rid of the key generation complexity and always output a generic message key
let's got with b
we can get away with a couple of very specific messages, but if none of those exist, we should fallback to a very generic message.