| • Vibhabamba | |
| Apr 3 2015, 1:44 AM |
| F111488: margin.gif | |
| Apr 11 2015, 1:04 PM |
| F111423: Screen_Shot_2015-04-11_at_5.48.56_PM.png | |
| Apr 11 2015, 12:58 PM |
| F111432: Screen_Shot_2015-04-11_at_5.50.08_PM.png | |
| Apr 11 2015, 12:58 PM |
| F111450: Screen_Shot_2015-04-11_at_5.51.52_PM.png | |
| Apr 11 2015, 12:58 PM |
| F111479: Screen_Shot_2015-04-11_at_5.52.17_PM.png | |
| Apr 11 2015, 12:58 PM |
| F111473: Screen_Shot_2015-04-11_at_6.00.56_PM.png | |
| Apr 11 2015, 12:58 PM |
| F111454: Screen_Shot_2015-04-11_at_5.53.46_PM.png | |
| Apr 11 2015, 12:58 PM |
| F111468: Screen_Shot_2015-04-11_at_6.00.42_PM.png | |
| Apr 11 2015, 12:58 PM |
Reduce the top padding between text and image in the portrait hovercard.
This will make an additional line show up. Further, it will solve the 'run in' issue on Greek Wikipedia, which is critical.
Setup text area such that 2 more lines are visible in the landscape card.
Request more lines from text extract, so that after eliminating parenthesis, the first sentence can be read in 90% cases.
Any clearance from Ori is fine.
prtksxna - Regarding Step 1:
We need to reduce top padding and maybe adjust leading so we can accommodate one more line in portrait hovercard.
This might be easiest accomplished on a hangout together.
it will solve the 'run in' issue on Greek Wikipedia
Could you provide a link for this issue?
Request more lines from text extract, so that after eliminating parenthesis, the first sentence can be read in 90% cases.
Discussing this in T93160#1177416.
To see the affect of the reduced font size and leading you can add the following code to your common.css —
/* Hovercards - T94957 */ .mwe-popups { font-size: 14px; line-height: 20px; } .mwe-popups.mwe-popups-is-tall .mwe-popups-extract { height: 142px; }
Adding screenshots from English, Chinese and Catalan Wikipedias.
English
| Old | New |
|---|---|
 |  |
 |  |
 |  |
 |  |
 |  |
 |  |
Chinese
| Old | New |
|---|---|
 |  |
 |  |
 |  |
 |  |
 |  |
 |  |
Catalan
| Old | New |
|---|---|
 |  |
 |  |
 |  |
 |  |
 |  |
 |  |
@Vibhabamba, I am sorry for the delay in providing these.
@Vibhabamba had also asked me to reduce the top margin of the excerpt when the image is landscape.
I had some issues when I was trying to do this. Will give an update on this soon.
@Prtksxna The screenshots with additional lines of text, reduced font size and leading look pretty good.
@Prtksxna That margin you highlighted looks like its 36px in height and it can go down to 29px, so reduce it by 5px or so and please post some screenshots? Thank you so much for posting old and new screenshots. That was super helpful!
As I mentioned in T94957#1200996, it'll take a while before I can show you those screenshots. Some time next week for sure.
@Prtksxna Thats totally fine. Fixing the extra margin is *not critical* for release, that can be fixed next week.
Change 202627 had a related patch set uploaded (by Prtksxna):
Update font-size and line-height
@Jaredzimmerman-WMF (re-ping with correct username, in case that helps email-filters etc. :)
Change 204796 had a related patch set uploaded (by Ori.livneh):
Update font-size and line-height
Change 204797 had a related patch set uploaded (by Ori.livneh):
Update font-size and line-height
I'm assuming this is fixed as there are lots of patches linked to this. Please reopen if not.