Page MenuHomePhabricator

Problems due to VE running on moderation field which is plaintext
Closed, ResolvedPublic

Description

I tried to link
https://www.mediawiki.org/wiki/Topic:Setw3d9fjilxwy78
to T94122 when locking the topic, but a few parsoid attributes where displayed instead of a working link.

Event Timeline

He7d3r created this task.Apr 6 2015, 3:55 PM
He7d3r updated the task description. (Show Details)
He7d3r raised the priority of this task from to Needs Triage.
He7d3r added a subscriber: He7d3r.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 6 2015, 3:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

We might be enabling visual editor in the reason field, but the intention there was for it to always be plaintext. Links and other wikitext should be in the topic summary. At a higher level many people probably don't know how it is supposed to behave, we should reevaluate from a design perspective.

EBernhardson triaged this task as High priority.Apr 6 2015, 5:52 PM
He7d3r added a comment.Apr 6 2015, 6:15 PM

Restricting that field to plaintext will not work, as it is supposed to be the equivalent of closing discussions with templates like
https://pt.wikipedia.org/w/index.php?diff=41810112
and
https://pt.wikipedia.org/w/index.php?diff=41805286
where wiki syntax is widely used.

It's not set in stone, but it's always been plaintext.

Lock reason is not the equivalent to a discussion close template. The summary is the equivalent location for a discussion close template, and allows full wikitext.

He7d3r added a comment.EditedApr 6 2015, 6:45 PM

[off-topic] Er, the summary is not available when one is closing (locking, in Flow's terminology) a discussion, only the lock reason textarea. Why do we need both anyway? (Just make the summary obligatory for any user locking a topic, as in T62552...) Also, since one can't add a summary once the topic is locked, this will result in people locking->unlocking->summarizing->locking again, instead of just locking+summarizing the discussion in one step.

Mattflaschen-WMF renamed this task from "data-parsoid" JSON shows up in Flow's reason field to Problems due to VE running on moderation field which is plaintext.
Mattflaschen-WMF set Security to None.

Change 206063 had a related patch set uploaded (by Mattflaschen):
Don't run editors on plaintext fields

https://gerrit.wikimedia.org/r/206063

Change 206063 merged by jenkins-bot:
Don't run editors on plaintext fields

https://gerrit.wikimedia.org/r/206063

Mattflaschen-WMF closed this task as Resolved.Apr 25 2015, 3:12 AM