Page MenuHomePhabricator

[Bug] Save button inactive when changing language on monolingual text statements
Closed, ResolvedPublic

Description

When editing an existing statement of property type monolingual text and changing the language, the save button does not become active.

This can be worked around by changing the actual text and back, then save works.

Event Timeline

WMDE-Fisch raised the priority of this task from to Needs Triage.
WMDE-Fisch updated the task description. (Show Details)
WMDE-Fisch added a subscriber: WMDE-Fisch.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2015, 12:21 PM
JanZerebecki triaged this task as Normal priority.May 16 2015, 8:12 PM
JanZerebecki updated the task description. (Show Details)
JanZerebecki set Security to None.
JanZerebecki moved this task from incoming to ready to go on the Wikidata board.
Jonas renamed this task from Save button inactive when changing language on monolingual text statements to [Bug] Save button inactive when changing language on monolingual text statements.Aug 14 2015, 8:13 AM
thiemowmde raised the priority of this task from Normal to High.Dec 22 2015, 1:53 PM
thiemowmde added projects: ValueView, Regression.
Jonas claimed this task.Jan 5 2016, 7:51 PM

Change 262688 had a related patch set uploaded (by Jonas Kress (WMDE)):
Fixes: [Bug] Save button inactive when changing mono language

https://gerrit.wikimedia.org/r/262688

Change 262688 merged by jenkins-bot:
Fixes: [Bug] Save button inactive when changing mono language

https://gerrit.wikimedia.org/r/262688

hoo closed this task as Resolved.Jan 6 2016, 6:46 PM
hoo removed a project: Patch-For-Review.
Jonas reopened this task as Open.Feb 1 2016, 4:57 PM

@adrianheine it broke again :(
BTW it works when inserting a language code and press <enter>

I never saw this work as intended, to be honest.

Sorry, we might have broken it again before it could be deployed.

hoo added a subscriber: hoo.Feb 1 2016, 5:12 PM

Please note that the patch mentioned above has not been deployed to Wikidata or testwikidata, so it's expected to be still broken there. I don't know whether it's broken again on master or not.

adrianheine closed this task as Resolved.Feb 2 2016, 8:17 AM

Works for me with ValueView 0.15.8.