When applying the "link rewrite" magic to the history page, we should prefetch all the labels we need, like we already do for watchlist and recentchanges.
LabelPrefetchHookHandlers is triggered by the ChangesListInitRows hook for watchlist and recentchanges. A similar hook, probably in HistoryPager, would be needed to do the same for history pages.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Introduce PageHistoryPager::doBatchLookups hook. | mediawiki/core | master | +12 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | hoo | T55247 History and diff pages should show labels of properties and items in edit summaries | |||
| Declined | hoo | T95672 Prefetch labels on history pages |
Blocked on core patch that introduces the hook we'll use to trigger the pre-fetching: Ie10ef99154d
Change 204526 had a related patch set uploaded (by Daniel Kinzler):
Introduce PageHistoryPager::doBatchLookups hook.
Change 204526 merged by jenkins-bot:
Introduce PageHistoryPager::doBatchLookups hook.
For the record, now that the hook exists in core, we still need code that hooks in and does the pre-fetching.
I just looked at this for a bit and it seems like we only prefetch the labels of the entities that have been changed (eg. on Special:RecentChanges), but we never prefetch any data of the entities that are being referred to (in the comments). Due to that I'm not really sure how useful that kind of prefetching would be for history pages/ individual diffs... probably not worth the hazel.
This doesn't make sense, we need to actually fix T97126 (per above and the discussion on Thursday).