Reference span without reference list crashes parsoid during HTML to Wikitext conversion
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	santhosh
	Apr 16 2015, 10:06 AM

Description

Problematic HTML Content: http://etherpad.wikimedia.org/p/parsoid-crash

Causes 503 at http://parsoid-lb.eqiad.wikimedia.org while doing HTML to wikitext conversion
It succeeds in http://parsoid.wmflabs.org/ and returns wiki text, which I understand as unmaintained parsoid instance.

Content Translation tries to include the reference list(or references) in the translation whenever a reference is added to translation. But right now it is not a 100% guaranteed one. For example http://en.wikipedia.beta.wmflabs.org/wiki/Special:ContentTranslation?page=Dong+Qichang&from=fr&to=es&targettitle=Dong+Qichang&debug=1 is one such instance where our references inclusion fails . We will investigate this separately,

But does it make sense to avoid 503s in this kind of cases?

Details

	Subject	Repo	Branch	Lines +/-
	Make sure <references> not getting removed from source	mediawiki/extensions/ContentTranslation	master	+23 -0

Customize query in gerrit

Related Objects

Mentioned In: T97206: RFC: Re-evaluate varnish-level request-restart behavior on 5xx
rECTX3e06640c9319: Make sure <references> not getting removed from source
rMEXTb7256c5332e9: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation…
T94690: log more details about publishing error
rOPUPc28b8150164c: Fix 5xx retry for parsoid backend

Event Timeline

santhosh created this task.Apr 16 2015, 10:06 AM

santhosh raised the priority of this task from to High.

santhosh updated the task description. (Show Details)

santhosh added projects: Parsoid, ContentTranslation.

santhosh subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 16 2015, 10:06 AM

santhosh renamed this task from HTML snippet crashes parsoid during HTML to Wikitext conversion to Reference span without reference list crashes parsoid during HTML to Wikitext conversion.Apr 16 2015, 10:38 AM

santhosh updated the task description. (Show Details)

santhosh set Security to None.

Change 204487 had a related patch set uploaded (by Santhosh):
Make sure references templates not getting removed from source

https://gerrit.wikimedia.org/r/204487

gerritbot added a project: Patch-For-Review.Apr 16 2015, 11:03 AM

I think this had come up earlier in some other context.

But, if you are going to use data-mw.body.id in <ref>s when sending that to Parsoid, then, you have to include the <references/> section output as well since the actual HTML for serialization is present in that section and the <ref> cannot be serialized in isolation.

If you want to serialize a <ref> in isolation, you have to provide data-mw.body.html.

But, looks like our debugging API hasn't been updated to return the proper error messages -- we shouldn't return a 503 for sure, but instead return a useful error message.

• marcoil subscribed.Apr 17 2015, 3:01 PM

The 503 should be fixed by https://gerrit.wikimedia.org/r/#/c/200732/

Arlolra mentioned this in rOPUPc28b8150164c: Fix 5xx retry for parsoid backend.Apr 17 2015, 5:08 PM

santhosh mentioned this in T94690: log more details about publishing error.Apr 20 2015, 8:07 AM

• ssastry moved this task from Needs Triage to Non-Parsing-Team Tasks on the Parsoid board.Apr 21 2015, 3:49 AM

Change 204487 merged by jenkins-bot:
Make sure <references> not getting removed from source

https://gerrit.wikimedia.org/r/204487

Diffusion mentioned this in rMEXTb7256c5332e9: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Apr 21 2015, 3:58 PM

santhosh mentioned this in rECTX3e06640c9319: Make sure <references> not getting removed from source.Apr 21 2015, 3:59 PM

BBlack mentioned this in T97206: RFC: Re-evaluate varnish-level request-restart behavior on 5xx.Apr 26 2015, 2:46 PM

• Nikerabbit removed a project: Patch-For-Review.Apr 30 2015, 6:52 AM

What's the status of this? Does this still happen?