Page MenuHomePhabricator
Create Task
Maniphest T96257

Editing block warning appears only after i tried to save (for not-logged-in users)
Closed, ResolvedPublic
Actions

Description

So I discovered today that if a blocked user or IP address attempts to edit on the mobile version of Wikipedia, they will be allowed to edit the code, preview and put in an edit summary, before they are notified that they are blocked, and any work they have put in is lost. Not only that, the block notice in not clickable and it gives no reason why you are blocked and no method of appealing. If mobile editor is to become more popular as we are being told, this needs sorting out. Sent here from Village Pump.

Mobile_English_Wikipedia_Block_Notice.png (891×1 px, 121 KB)

Details

SubjectRepoBranchLines +/-
Check, if the user is blocked from editing before try to save the editmediawiki/extensions/MobileFrontendmaster+58 -9
Customize query in gerrit

Related Objects

Event Timeline

EoRdE6 created this task.Apr 16 2015, 3:14 PM
EoRdE6 raised the priority of this task from to Medium.
EoRdE6 updated the task description. (Show Details)
EoRdE6 added a project: Web-Team-Backlog.
EoRdE6 added subscribers: TheDJ, • Rdicerb, Aklapper.
Jdlrobson added subscribers: EoRdE6, Nemo_bis, Florian, Jdlrobson.Apr 16 2015, 7:59 PM

Oh dear. Thanks for the heads up @EoRdE6. I suspect this is an oversight related to the anonymous editing change. Was the user anonymous at the time or logged in? cc @Florian @Nemo_bis

Jdlrobson moved this task from Incoming to 2015-16 Q3 on the Web-Team-Backlog board.Apr 16 2015, 8:00 PM
Jdlrobson added a project: Mobile-Web-Sprint-45-Snakes-On-A-Plane.Apr 16 2015, 8:03 PM
Jdlrobson set Security to None.
EoRdE6 added a comment.Apr 16 2015, 9:11 PM

@Jdlrobson Anonymous at the time (thankfully I don't have a blocked account to test that).

• Rdicerb added a subscriber: • Moushira.Apr 17 2015, 4:56 AM

Thank you so much for making this ticket @EoRdE6! Making sure this is on @Moushira's radar

Florian claimed this task.Apr 17 2015, 5:42 AM

If the user isn't logged in, the editor don't know, if the user is blocked from editing or not (it's a bit more difficult as it sounds because of another caching behavior for anonymous users), so we can't lock the edit pencil when the user isn't logged in and blocked from editing (it's like the desktop UI where you see the "Edit" button and when you click it you'll see the view source), as long as we don't make an Api call every page view, which would be terrible. But the editor shouldn't definitely check the permission for the current user, if the edit pencil is clicked. Let me look into it, how we can fix this.

Thanks @EoRdE6 for pointing this out!

Florian raised the priority of this task from Medium to High.Apr 17 2015, 5:42 AM
Florian added a comment.Apr 17 2015, 8:23 AM

With the change following, you will see a toast notice with the information, that your account was blocked with the info who made this block and with which reason.

Unbenannt.PNG (539×336 px, 28 KB)

gerritbot subscribed.Apr 17 2015, 8:43 AM

Change 204716 had a related patch set uploaded (by Florianschmidtwelzow):
Check, if the user is blocked from editing before try to save the edit

https://gerrit.wikimedia.org/r/204716

gerritbot added a project: Patch-For-Review.Apr 17 2015, 8:43 AM
phuedx moved this task from Needs Analysis to Code Review on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.Apr 17 2015, 5:09 PM
phuedx mentioned this in T96352: MobileFrontend should show the correct reason, why a user can't edit a page.Apr 17 2015, 5:17 PM
Florian renamed this task from Mobile Web Block Warning to Editing block warning appears only after i tried to safe (for not-logged-in users).Apr 17 2015, 5:23 PM
EoRdE6 added a comment.Apr 17 2015, 8:27 PM

@Florian Your screenshot says "You will not be able to safe your edit". Is that supposed to say " You will not be able to save your edit"?

Florian added a comment.Apr 17 2015, 8:28 PM

@EoRdE6 You're right! My fault :) Thanks for the catch.

Nemo_bis renamed this task from Editing block warning appears only after i tried to safe (for not-logged-in users) to Editing block warning appears only after i tried to save (for not-logged-in users).Apr 17 2015, 10:17 PM
phuedx moved this task from Code Review to -1 (Needs More Work) on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.Apr 20 2015, 5:34 PM
phuedx moved this task from -1 (Needs More Work) to Code Review on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.Apr 22 2015, 9:23 AM
• KLans_WMF moved this task from 2015-16 Q3 to Old Unorganized Resolved Tasks on the Web-Team-Backlog board.Apr 23 2015, 9:09 PM
gerritbot added a comment.Apr 27 2015, 5:05 PM

Change 204716 merged by jenkins-bot:
Check, if the user is blocked from editing before try to save the edit

https://gerrit.wikimedia.org/r/204716

Florian mentioned this in rMEXTc8aca63aa71e: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Apr 27 2015, 5:05 PM
Jdlrobson mentioned this in rEMFRc76efbda2dc4: Check, if the user is blocked from editing before try to save the edit.Apr 27 2015, 5:05 PM
phuedx closed this task as Resolved.Apr 27 2015, 6:32 PM
phuedx moved this task from Code Review to Done on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.
phuedx subscribed.
• Phabricator_maintenance moved this task from Old Unorganized Resolved Tasks to 2014-15 Q4 on the Web-Team-Backlog board.Mar 7 2018, 1:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits