Page MenuHomePhabricator
Create Task
Maniphest T97401

Source editor should remain visible, but disabled, while VE is loading
Closed, ResolvedPublic
Actions

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make editor switching look nicermediawiki/extensions/Flowmaster+31 -10
Keep source editor visible but disabled while VE loadsmediawiki/extensions/Flowmaster+12 -10
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Apr 28 2015, 10:39 AM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added projects: StructuredDiscussions, Design.
Esanders subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 28 2015, 10:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Mattflaschen-WMF triaged this task as Medium priority.Apr 28 2015, 5:47 PM
• Mattflaschen-WMF subscribed.
Catrope added a subtask: T97443: Add Handlebars helper for embedding OOUI widgets.Apr 28 2015, 5:51 PM
Catrope removed a subtask: T97443: Add Handlebars helper for embedding OOUI widgets.
Catrope claimed this task.Apr 28 2015, 9:16 PM
gerritbot subscribed.Apr 29 2015, 1:49 AM

Change 207295 had a related patch set uploaded (by Catrope):
Keep source editor visible but disabled while VE loads

https://gerrit.wikimedia.org/r/207295

gerritbot added a project: Patch-For-Review.Apr 29 2015, 1:49 AM
Catrope added a project: Collaboration-Team-Sprint-A-2015-05-06.Apr 29 2015, 1:49 AM
Catrope set Security to None.
Catrope moved this task from Sprint A - ends May 6 to Needs Review on the Collaboration-Team-Sprint-A-2015-05-06 board.
SBisson moved this task from Needs Review to Code Review Started on the Collaboration-Team-Sprint-A-2015-05-06 board.Apr 29 2015, 8:14 PM
gerritbot added a comment.Apr 29 2015, 8:15 PM

Change 207295 merged by jenkins-bot:
Keep source editor visible but disabled while VE loads

https://gerrit.wikimedia.org/r/207295

SBisson moved this task from Code Review Started to QA Review on the Collaboration-Team-Sprint-A-2015-05-06 board.Apr 29 2015, 8:16 PM
Diffusion mentioned this in rMEXT1f35a57d7ade: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Apr 29 2015, 8:16 PM
Catrope mentioned this in rEFLW6d6601516ca3: Keep source editor visible but disabled while VE loads.Apr 29 2015, 8:17 PM
Etonkovidova subscribed.Apr 30 2015, 9:01 PM

Checked on http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow_QA

switch_to_editor.mov3 MBDownload

My understanding of expected behaviour:

  1. I type something in Source editor - and click to switch to VE.
  2. My typed content is faded but keeps being displayed until VE is fully loaded.

I attached QuickTime screen recording of how it looks now. 'Post a new message to "Talk: Flow QA" ' is displayed instead of the typed content.

gerritbot added a comment.May 1 2015, 12:11 AM

Change 208031 had a related patch set uploaded (by Catrope):
Make editor switching look nicer

https://gerrit.wikimedia.org/r/208031

Catrope moved this task from QA Review to Needs Review on the Collaboration-Team-Sprint-A-2015-05-06 board.May 1 2015, 5:35 PM
matthiasmullie moved this task from Needs Review to Code Review Started on the Collaboration-Team-Sprint-A-2015-05-06 board.May 4 2015, 12:26 PM
matthiasmullie moved this task from Code Review Started to QA Review on the Collaboration-Team-Sprint-A-2015-05-06 board.May 5 2015, 5:45 PM
gerritbot added a comment.May 5 2015, 5:48 PM

Change 208031 merged by jenkins-bot:
Make editor switching look nicer

https://gerrit.wikimedia.org/r/208031

Diffusion mentioned this in rMEXTb321fc501b7d: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….May 5 2015, 5:48 PM
Catrope mentioned this in rEFLW83a998610dc1: Make editor switching look nicer.May 5 2015, 5:49 PM
Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Sprint-A-2015-05-06 board.May 5 2015, 11:51 PM
• DannyH closed this task as Resolved.May 6 2015, 8:35 PM
• DannyH subscribed.

works on Beta

• DannyH moved this task from Product Review to Done on the Collaboration-Team-Sprint-A-2015-05-06 board.May 6 2015, 8:35 PM
• DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.May 13 2015, 12:15 AM
Catrope merged a task: T94111: Show an empty textarea with a loading indicator in center when editor (i.e. VE) is loading.Jun 23 2015, 6:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits