Maniphest T97621

In iOS Safari, after opening the hamburger menu, clicking on the greyed-out article doesn't close the hamburger menu
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kaldari
	Apr 30 2015, 1:50 AM

Tags

Referenced Files

None

Subscribers

Description

Tested in local master and English Wikipedia in both iOS 8 and 6.

Details

	Subject	Repo	Branch	Lines +/-
	Allow ios users to close the main menu	mediawiki/extensions/MobileFrontend	wmf/1.26wmf4	+4 -3
	Allow ios users to close the main menu	mediawiki/extensions/MobileFrontend	wmf/1.26wmf3	+4 -3
	Allow ios users to close the main menu	mediawiki/extensions/MobileFrontend	master	+4 -3
	Revert "Append drawers to body so they can work in other skins"	mediawiki/extensions/MobileFrontend	master	+2 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T97621 In iOS Safari, after opening the hamburger menu, clicking on the greyed-out article doesn't close the hamburger menu
		Declined		Jdlrobson	T98200 View::events doesn't work when el is body and user is using ios

Event Timeline

kaldari created this task.Apr 30 2015, 1:50 AM

kaldari raised the priority of this task from to High.

kaldari updated the task description. (Show Details)

kaldari added projects: Web-Team-Backlog, Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story.

kaldari subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2015, 1:50 AM

kaldari moved this task from Needs Analysis to To Do on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.May 1 2015, 12:26 AM

kaldari moved this task from To Do to Needs Analysis on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.

phuedx moved this task from Needs Analysis to To Do on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.May 1 2015, 2:57 PM

phuedx moved this task from Incoming to Old Unorganized Resolved Tasks on the Web-Team-Backlog board.May 1 2015, 3:03 PM

Liuxinyu970226 subscribed.May 3 2015, 2:35 PM

phuedx claimed this task.May 5 2015, 11:04 AM

phuedx moved this task from To Do to Doing on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.

phuedx set Security to None.

Moved this over to Doing prematurely.

phuedx claimed this task.May 5 2015, 12:19 PM

phuedx moved this task from To Do to Doing on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.

The .transparent-shield element doesn't seem to be bubbling click events.

Change 208953 had a related patch set uploaded (by Phuedx):
Revert "Append drawers to body so they can work in other skins"

https://gerrit.wikimedia.org/r/208953

gerritbot added a project: Patch-For-Review.May 5 2015, 1:34 PM

According to git bisect this regression was caused by 203242.

@Jdlrobson: I'm unsure of blanket reverting the change. What do you think?

Jdlrobson mentioned this in T98184: Overlays do not work in non-Minerva skins.May 5 2015, 6:23 PM

There's an ominous remark about changing #mw-mf-viewport to body in Overlay.js.

phuedx reassigned this task from phuedx to Jdlrobson.May 5 2015, 7:37 PM

Change 209047 had a related patch set uploaded (by Jdlrobson):
Allow ios users to close the main menu

https://gerrit.wikimedia.org/r/209047

Change 208953 abandoned by Jdlrobson:
Revert "Append drawers to body so they can work in other skins"

Reason:
See https://gerrit.wikimedia.org/r/#/c/209047/

https://gerrit.wikimedia.org/r/208953

Change 209047 merged by jenkins-bot:
Allow ios users to close the main menu

https://gerrit.wikimedia.org/r/209047

Jdlrobson mentioned this in rEMFRa8626d210516: Allow ios users to close the main menu.May 6 2015, 6:43 AM

Diffusion mentioned this in rMEXT1a46d1622ec1: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….May 6 2015, 6:44 AM

This is a symptom of T98200.

phuedx moved this task from Doing to Ready for Signoff on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.May 6 2015, 9:37 AM

I've tested the main menu in the iOS simulator locally.

Change 209322 had a related patch set uploaded (by Robmoen):
Allow ios users to close the main menu

https://gerrit.wikimedia.org/r/209322

Change 209323 had a related patch set uploaded (by Robmoen):
Allow ios users to close the main menu

https://gerrit.wikimedia.org/r/209323

Change 209322 abandoned by Robmoen:
Allow ios users to close the main menu

https://gerrit.wikimedia.org/r/209322

Change 209323 merged by jenkins-bot:
Allow ios users to close the main menu

https://gerrit.wikimedia.org/r/209323

• rmoen mentioned this in rEMFR44eaad204039: Allow ios users to close the main menu.May 6 2015, 11:33 PM

Liuxinyu970226 unsubscribed.May 7 2015, 12:46 AM

Jdlrobson closed subtask T98200: View::events doesn't work when el is body and user is using ios as Declined.Jul 7 2016, 4:39 PM

• Phabricator_maintenance moved this task from Old Unorganized Resolved Tasks to 2014-15 Q4 on the Web-Team-Backlog board.Mar 7 2018, 1:27 AM